Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1006
Summary
When LLM clients call
task_editover MCP to append review comments or update specific fields, some models populate omitted parameters with literal TypeScript schema signatures (e.g.planSet?: string,acceptanceCriteriaSet?[],commentAuthor?: string,commentsAppend?[]: string[]).Previously,
task_editaccepted these strings directly into comment arrays and update fields, cluttering task history with schema type strings. In addition, comment-only updates risked clearing other task metadata if empty arrays or no-op fields were passed.What changed
src/utils/task-edit-builder.ts:isSchemaPlaceholderto filter echoed TypeScript parameter signatures and type declarations out of string and array update fields.isCommentPlaceholderso legitimate short user comments (likestatus?ortitle?) are preserved, while signatures likestatus?: TaskStatusorplanSet?: stringare discarded.modifiedFiles: []while treating whitespace-only arrays as no-ops.src/mcp/validation/validators.ts:src/mcp/utils/schema-generators.ts:task_createschema generation to advertise the configureddefaultStatus.src/test/task-edit-builder.test.ts&src/test/mcp-tasks.test.ts:Verification
bunx tsc --noEmit— cleanbun run check .— clean (426 files)bun test src/test/task-edit-builder.test.ts src/test/mcp-tasks.test.ts— 52 pass / 0 fail (343 assertions)