Skip to content

BACK-695 - Skip fetch when the requested Git remote is absent - #1023

Open
Lingikaushikreddy wants to merge 2 commits into
MrLesk:mainfrom
Lingikaushikreddy:issue-1020-skip-fetch-when-remote-missing
Open

Lingikaushikreddy wants to merge 2 commits into
MrLesk:mainfrom
Lingikaushikreddy:issue-1020-skip-fetch-when-remote-missing

Conversation

@Lingikaushikreddy

@Lingikaushikreddy Lingikaushikreddy commented Sep 17, 2026 •

Copy link
Copy Markdown

When a repository has an upstream remote but no origin, task reads try to fetch the missing origin and print a Git error. This change checks that the requested remote exists before fetching it, using the existing remote lookup. Repositories with that remote and offline mode keep their current behavior.

Fixes #1020.

Adds a regression for an upstream-only repository and updates existing fetch tests. The contributor reproduced the plain search error; the reported TUI display problem was not reproduced directly. CI passed on this head: Linux, macOS, and Windows tests and compiled smoke checks, plus the Nix package build. Type checks and formatting/lint checks passed in CI.

…#1020)

fetchRemote() only checked that some remote existed before running
`git fetch origin`. In a repository whose only remote has another name,
every task read failed with exit code 128 and printed the error into the
CLI output and the board TUI.
@Lingikaushikreddy

Lingikaushikreddy commented Sep 17, 2026 •

Copy link
Copy Markdown
Author

Follow-up on the one test I flagged. I had only run board-tui-move.test.ts › "freezes the move set and ignores Escape…" in isolation after my change, which was weak evidence for calling it unrelated.

I've now run the full suite on unmodified main (c0ec546, without this branch): 2871 pass, 1 fail, and the failure is that same test. So it fails under full-suite load independently of this change.

Also, to be exact about the repro in the description: I reproduced the error text in backlog search --plain output, which is the same refreshRemoteRefsForTaskRead() path the reporter saw corrupting the board TUI. I did not reproduce the corrupted board itself, so treat that part as inference rather than something I measured.

@MrLesk MrLesk changed the title Skip remote fetch when the requested remote is not configured (#1020) BACK-695 - Skip fetch when the requested Git remote is absent Sep 27, 2026
@MrLesk

MrLesk commented Sep 27, 2026

Copy link
Copy Markdown
Owner

@codex review

Alex's agent

@radupotop

Copy link
Copy Markdown

Hi Alex, is the codex review stuck? Would be great to have this reviewed and merged in. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Missing git origin triggers verbose warning / corrupts backlog board TUI

3 participants