Skip to content

BACK-684 - Move the acceptance-criteria ring into the web card header - #995

Merged
MrLesk merged 1 commit into
mainfrom
tasks/back-684-ring-header
Sep 2, 2026
Merged

BACK-684 - Move the acceptance-criteria ring into the web card header#995
MrLesk merged 1 commit into
mainfrom
tasks/back-684-ring-header

Conversation

@MrLesk

@MrLesk MrLesk commented Sep 2, 2026

Copy link
Copy Markdown
Owner

Summary

On web board cards the acceptance-criteria ring rendered on its own line under the title, so a 12px ring and a 3/5 label cost a full row of card height on every In Progress card with criteria. The ring is metadata, and the card already has a metadata row: the header with the task id, type and project badges on the left and the priority badge on the right.

This moves the ring into that header row and removes the standalone line, so cards with progress get shorter instead of taller.

What changed

src/web/components/TaskCard.tsx:

  • getPriorityBadge is now called once into a priorityBadge value.
  • The header's right side is a flex shrink-0 items-center gap-2 group that renders only when there is progress or a priority badge — a card with neither still renders nothing beside the id.
  • Inside the group the ring comes first and the priority chip last, so the chip stays flush right exactly where cards without progress already put it. The id/type/project group keeps min-w-0 and remains the only side that gives way.
  • The standalone <AcceptanceCriteriaProgress ... className="mt-2" /> line under the title is gone.

AcceptanceCriteriaProgress itself and the task list usage (density="list" in TaskList.tsx) are unchanged.

Verification

Rendered on a local browser board in both light and dark themes:

  • BACK-636 (Medium priority, 0/4) renders BACK-636 … ◯ 0/4 Med on one header line; BACK-684 (no priority, 0/4) renders the ring flush right. No progress node outside the header on either card, and both titles sit directly under the header.
  • Measured in the DOM: re-inserting the old standalone line under the title grew the BACK-636 card from 101px to 129px, so the header placement saves 28px (~22%) per card with progress.
  • Squeezed a card carrying a type badge from 260px down to 130px: the header stayed a single 20px line with zero overflow — the right group holds its width and the left group truncates instead of wrapping.

Tests — src/test/web-task-acceptance-progress.test.tsx gains four card cases: ring plus priority badge (ring inside the header row, exactly one progress node, badge still last), ring without priority, priority without progress, and neither. The two placement cases fail against the pre-change component.

Gates:

  • bunx tsc --noEmit — clean
  • bun run check . — clean (425 files)
  • bun run test — 2859 pass, 8 skip, 1 fail: ContentStore > refreshes completed identity state when the completed corpus changes, a known local-only flake that passes when its file is run alone (67/67) and is unrelated to this change.

Task: BACK-684

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 2, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-02T22:17:17.618218Z 4fa4171 Manual request
🔒 Security Review Completed 2026-09-02T22:11:19.625570Z 4fa4171 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@MrLesk

MrLesk commented Sep 2, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🎉

Reviewed commit: 4fa4171212

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@MrLesk
MrLesk merged commit 97c45b7 into main Sep 2, 2026
10 checks passed
@MrLesk
MrLesk deleted the tasks/back-684-ring-header branch September 2, 2026 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant