BACK-684 - Move the acceptance-criteria ring into the web card header - #995
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Owner
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On web board cards the acceptance-criteria ring rendered on its own line under the title, so a 12px ring and a
3/5label cost a full row of card height on every In Progress card with criteria. The ring is metadata, and the card already has a metadata row: the header with the task id, type and project badges on the left and the priority badge on the right.This moves the ring into that header row and removes the standalone line, so cards with progress get shorter instead of taller.
What changed
src/web/components/TaskCard.tsx:getPriorityBadgeis now called once into apriorityBadgevalue.flex shrink-0 items-center gap-2group that renders only when there is progress or a priority badge — a card with neither still renders nothing beside the id.min-w-0and remains the only side that gives way.<AcceptanceCriteriaProgress ... className="mt-2" />line under the title is gone.AcceptanceCriteriaProgressitself and the task list usage (density="list"inTaskList.tsx) are unchanged.Verification
Rendered on a local browser board in both light and dark themes:
BACK-636(Medium priority, 0/4) rendersBACK-636 … ◯ 0/4 Medon one header line;BACK-684(no priority, 0/4) renders the ring flush right. No progress node outside the header on either card, and both titles sit directly under the header.BACK-636card from 101px to 129px, so the header placement saves 28px (~22%) per card with progress.Tests —
src/test/web-task-acceptance-progress.test.tsxgains four card cases: ring plus priority badge (ring inside the header row, exactly one progress node, badge still last), ring without priority, priority without progress, and neither. The two placement cases fail against the pre-change component.Gates:
bunx tsc --noEmit— cleanbun run check .— clean (425 files)bun run test— 2859 pass, 8 skip, 1 fail:ContentStore > refreshes completed identity state when the completed corpus changes, a known local-only flake that passes when its file is run alone (67/67) and is unrelated to this change.Task: BACK-684