fix(stlgeom): export STLMeshingDummy with DLL_HEADER#252
Open
ahojukka5 wants to merge 1 commit into
Open
Conversation
STLMeshingDummy is the free function that lets a caller supply a custom STLParameters when meshing an STL geometry (bypassing the global stlparam singleton that STLGeometry::GenerateMesh hardcodes) -- it's what upstream's own Python bindings (python_stl.cpp) call for exactly this reason. Its declaration in stlgeom.hpp had no DLL_HEADER export macro, unlike virtually every other public free function in this codebase (see e.g. general/template.hpp, meshing/boundarylayer.hpp, meshing/bisect.hpp for the established "DLL_HEADER extern <type> Name(...)" convention). Practical effect: on a shared-library build with default-hidden visibility, this symbol is compiled into stlgeommesh.cpp's object file but not exported from the resulting .dylib/.so, so any external binding layer linking against Netgen's public shared library gets an undefined-symbol error at link time when trying to call it directly, even though the header declares it as callable.
There was a problem hiding this comment.
Pull request overview
Exports netgen::STLMeshingDummy from the shared library by applying the project’s DLL_HEADER visibility macro to its public declaration, enabling external consumers (e.g., bindings) to link against the symbol in default-hidden visibility builds.
Changes:
- Adds
DLL_HEADERto theSTLMeshingDummyfree-function declaration instlgeom.hppto ensure it is exported from.so/.dylibbuilds.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
STLMeshingDummy is the free function that lets a caller supply a custom STLParameters when meshing an STL geometry (bypassing the global stlparam singleton that STLGeometry::GenerateMesh hardcodes) -- it's what upstream's own Python bindings (python_stl.cpp) call for exactly this reason. Its declaration in stlgeom.hpp had no DLL_HEADER export macro, unlike virtually every other public free function in this codebase (see e.g. general/template.hpp, meshing/boundarylayer.hpp, meshing/bisect.hpp for the established "DLL_HEADER extern Name(...)" convention).
Practical effect: on a shared-library build with default-hidden visibility, this symbol is compiled into stlgeommesh.cpp's object file but not exported from the resulting .dylib/.so, so any external binding layer linking against Netgen's public shared library gets an undefined-symbol error at link time when trying to call it directly, even though the header declares it as callable.