Fix EdgeDescriptor in parallel

[pbrubeck]

No description provided.

[connorjward]

Makes sense to me. Those sizes may not be zero on all ranks.

[connorjward]

Does this need a test?

[pbrubeck]

Does this need a test?

Those are the Firedrake tests that were previously broken

[connorjward]

Does this need a test?

Those are the Firedrake tests that were previously broken

Sure. But it's good practice to test things where they are implemented. It's a question of policy for @UZerbinati really.

[pbrubeck]

Makes sense to me. Those sizes may not be zero on all ranks.

That's not the issue, we weren't hanging in parallel. It's just that we needed to make sure that we added boundary labels consistently across ranks. We needed to attach labels on the netgen mesh even if they were empty

[UZerbinati]

@connorjward Policy?

[connorjward]

Sure. But it's good practice to test things where they are implemented. It's a question of policy for @UZerbinati really.

As in, do you want people to add tests whenever they make changes to the code? It's a requirement for Firedrake for instance. Not bothered either way but I think it's important to think about.