Skip to content

memory leak mitigation in minicraft server - #124

Open
AugustoVSoares wants to merge 10 commits into
mainfrom
feature/minicraft-memory-leak-mitigation
Open

memory leak mitigation in minicraft server#124
AugustoVSoares wants to merge 10 commits into
mainfrom
feature/minicraft-memory-leak-mitigation

Conversation

@AugustoVSoares

@AugustoVSoares AugustoVSoares commented May 14, 2026 •
edited by FrozenHart
Loading

Copy link
Copy Markdown
Contributor

Closes #122

  • Scheduled Reboots: Added a CronJob that triggers a kubectl rollout restart of the Minecraft deployment daily at 07:00 AM.
  • Graceful Shutdowns: Implemented STOP_SERVER_ANNOUNCE_DELAY (60s) to notify players in-game before the server shuts down.
  • Improved Reliability: Increased terminationGracePeriodSeconds to ensure sufficient time for both player notifications and world saving before pod termination.
  • RBAC Security: Created a dedicated ServiceAccount and scoped Role to allow the reboot job to patch the deployment without granting excessive cluster permissions.

https://kubernetes.io/docs/reference/access-authn-authz/rbac/

@FrozenHart
FrozenHart self-requested a review May 29, 2026 15:57
@FrozenHart
FrozenHart marked this pull request as ready for review May 29, 2026 16:58
@FrozenHart FrozenHart added Medium Priority Automations Related to automating user made actions games labels May 29, 2026
FrozenHart
FrozenHart requested changes May 29, 2026
View reviewed changes

@FrozenHart FrozenHart left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After this changes are made wait to deploy curently being used to test Longhorn

Comment thread services/games/minicraft/helm/minecraft/values.yaml Outdated
FrozenHart
FrozenHart requested changes May 29, 2026
View reviewed changes
Comment thread services/games/minicraft/helm/minecraft/templates/04-rbac.yaml Outdated
FrozenHart
FrozenHart requested changes May 29, 2026
View reviewed changes
Comment thread services/games/minicraft/helm/minecraft/templates/05-restart-cronjob.yaml Outdated
Comment thread services/games/minicraft/helm/minecraft/templates/04-rbac.yaml Outdated
Comment thread services/games/minicraft/helm/minecraft/templates/04-rbac.yaml Outdated
@AugustoVSoares

AugustoVSoares commented Jun 9, 2026

Copy link
Copy Markdown
Contributor Author

Moved configuration value to the values.yaml file, _helpers.tpl is not needed anymore so I removed it. 🫡

@AugustoVSoares
AugustoVSoares requested a review from FrozenHart June 9, 2026 15:59
@FrozenHart FrozenHart linked an issue Jun 10, 2026 that may be closed by this pull request
MiNIcraft - Convert server from Paper to Fabric #120
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FrozenHart FrozenHart Awaiting requested review from FrozenHart

Requested changes must be addressed to merge this pull request.

Assignees

@AugustoVSoares AugustoVSoares

Labels

Automations Related to automating user made actions games Medium Priority

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

MiNIcraft - Memory Leak Mitigation with Scheduled Reboots MiNIcraft - Convert server from Paper to Fabric

2 participants

@AugustoVSoares @FrozenHart