Repository navigation
docs(adrs): bring status lines in line with the code #2988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,10 @@ | ||
| # ADR-0979: Bounded-memory RLOG compaction merge | ||
|
|
||
| Status: Proposed | ||
| Status: Accepted (2026-10-14). | ||
| Partly implemented: D1 to D4 are in `crates/ravel-maintain/src/rlog.rs`, | ||
| `crates/ravel-maintain/src/config.rs` and `crates/ravel-logseg/src/ranged.rs`; | ||
| D5's `--merge-cursor-budget-bytes` flag is not built | ||
| (`services/ravel-cli/src/main.rs` has the other three flags only). | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. should_fix: The note overstates what landed of D5: |
||
|
|
||
| Extends ADR-0032 (RLOG L0→L1 compaction) and the ADR-0065 decision-4 memory | ||
| model as amended by issues #711 (memory split target), #748 (row-group fetch, | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,12 @@ | ||
| # ADR-1170: One process-wide memory budget for ravel-server | ||
|
|
||
| Status: Proposed | ||
| Status: Accepted (2026-10-14). | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. should_fix: Moving ADR-1170 to Accepted falsifies three sentences that cite it as Proposed, two of them in files this PR edits. |
||
| Partly implemented: decisions 1 and 2 are in `crates/ravel-memory/src/lib.rs` | ||
| and the fetchers under `crates/ravel-query/src/`, decisions 3 and 4 in | ||
| `services/ravel-server/src/config.rs` and | ||
| `services/ravel-server/src/metrics.rs`; decision 3's measured overhead | ||
| reserve is not built (`MEMORY_OVERHEAD_RESERVE_BYTES` is a provisional | ||
| 2 GiB placeholder pending the #1256 calibration run). | ||
|
|
||
| ## Context | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Same class as the ADR-1170 finding, one file and outside the diff: accepting ADR-0979 leaves a stale citation of it as Proposed.
Failure: a reader of the TLA+ suite's maintenance row is told the compaction convergence gap rests on a Proposed decision, when the decision is now Accepted and D1-D4 have landed.
Evidence: docs/adrs/1113-tla-verification-suite.md:31, "ADR-0979 is Proposed and its fail-closed convergence path ships".