UpdateManager: clear task handle when GUI update cannot start - #22
Open
jamesmulcahy wants to merge 1 commit into
Open
jamesmulcahy wants to merge 1 commit into
jamesmulcahy wants to merge 1 commit into
Conversation
If update_gui could not get the NSPanel config it deleted its task without clearing _current_update_task, so all later update commands were ignored until reboot. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01X7aYyRjzk53Sd7gxF46E3u
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
If
update_guicannot get the NSPanel config, it logs an error and deletes its task, but leavesUpdateManager::_current_update_taskpointing at the deleted task. Every command handler checks_current_update_task == NULLbefore starting an update, so all laterfirmware_update,firmware_update_forceandtft_updatecommands are silently ignored until the panel reboots.This clears
_current_update_taskbefore the task deletes itself, matching whatupdate_firmwarealready does.🤖 Generated with Claude Code
https://claude.ai/code/session_01X7aYyRjzk53Sd7gxF46E3u