UpdateManager: abort HTTPS OTA handle on failure - #23
Open
jamesmulcahy wants to merge 1 commit into
Open
jamesmulcahy wants to merge 1 commit into
jamesmulcahy wants to merge 1 commit into
Conversation
When esp_https_ota_get_img_desc or esp_https_ota_perform failed the handle was never released, leaking the HTTP client, socket and OTA buffer on every failed firmware update. Call esp_https_ota_abort on those paths (esp_https_ota_finish already frees the handle itself). Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01X7aYyRjzk53Sd7gxF46E3u
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In
_update_firmware_ota, ifesp_https_ota_get_img_descfails, oresp_https_ota_performreturns an error (e.g. the connection drops mid-download), the function returns without releasing the OTA handle. Each failed update leaks the HTTP client, its socket, the OTA write buffer and the handle itself.This calls
esp_https_ota_aborton those two paths. Theesp_https_ota_finishpath is unchanged: in ESP-IDF 5.5esp_https_ota_finishfrees the handle whether it succeeds or not, so aborting there would be a double free.Retrying after a failure already worked (
esp_ota_beginonly refuses the running partition), so this is a leak fix rather than a functional change.Related: #18 touches the same failure branches (it replaces
FIRMWARE_UPDATE_FINISHEDwith a newFIRMWARE_UPDATE_FAILEDevent there), so whichever merges second will need a small rebase.🤖 Generated with Claude Code
https://claude.ai/code/session_01X7aYyRjzk53Sd7gxF46E3u