Remove legacy v1 time-entry picker from scan kiosk - #219
Merged
Conversation
The scan kiosk's sign-out Adjust screen supported two time-entry UIs, selected by the per-session easyTimeEntry config flag: the legacy 24-hour numeric keypad, and a 12-hour keypad with an explicit confirm step (formerly ScanModalDateTimeV2). Make the newer picker the only option: drop the flag and all v1 branching from ScanScreenAdjust, delete the legacy ScanModalDateTime modal, rename the V2 modal to ScanModalDateTime, and remove the "Easy time entry" toggle from the session admin form. Also drop the easyTimeEntry references from tests and local seed fixtures/docs, since only one picker now exists. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DoAKMBi1JjU4XcMew4JPmT
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The scan kiosk's sign-out "Adjust" screen had two time-entry UIs, selected by the per-session
easyTimeEntryconfig flag:This makes V2 the only option in code, ignoring the session config var per the task, and removes all traces of v1:
ScanScreenAdjust.tsx: removed alleasyTimeEntrybranching, the legacy "Day" row, next-day rollover logic, and theeasyTimeEntryprop — the component now always behaves like the old V2 path.ScanModalDateTime.tsxmodal; renamedScanModalDateTimeV2.tsx→ScanModalDateTime.tsx(and its test file) since it's now the only picker.ScanController.tsx: dropped theeasyTimeEntryderivation/prop passthrough.SessionForm.tsx(admin UI): removed the "Easy time entry" checkbox and its config read/write helpers — the setting no longer does anything.ScanScreenAdjust.test.tsxandKioskMain.test.tsxto drop the now-meaninglesseasyTimeEntryflag from test setup.api/tests/seed_fixtures.rs: removed the test asserting both branches are seeded, since there's only one branch now.local/seed/synthetic.json/local/examples/README.md: clearedeasyTimeEntryfrom the fixture kiosk config and swapped the examplesession set-config-keycommand for one that still does something (smallCategories).No GraphQL schema or backend changes were needed —
Session.configis an opaque JSON blob the Rust backend never parses.Test plan
cd web && npx tsc -b— type-checks cleancd web && npx eslinton all touched files — cleancd web && npx vitest runonScanScreenAdjust.test.tsx,ScanModalDateTime.test.tsx,KioskMain.test.tsx— 37 passedcd web && npx prettier --check— clean (one file auto-fixed)cd api && cargo test --test seed_fixtures— 7 passedcd api && cargo clippy --all-targets -- -D warnings— cleancd api && cargo fmt --check— clean🤖 Generated with Claude Code
https://claude.ai/code/session_01DoAKMBi1JjU4XcMew4JPmT
Generated by Claude Code