Repository navigation
fix(lp1): tailor remediation to manifest type - #402
Merged
Merged
Conversation
Signed-off-by: green3sf <222944370+green3sf@users.noreply.github.com>
rng1995
approved these changes
Aug 20, 2026
rng1995
left a comment
Collaborator
There was a problem hiding this comment.
[SkillSpector Review]
Approved. LP1 remediation now follows the declaration shape actually in use: Agent Skills receive allowed-tools guidance and MCP manifests receive permissions guidance. The runtime fallback, defaults, documentation, and regressions are aligned; required CI is green.
rng1995
enabled auto-merge (squash)
August 20, 2026 22:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #300.
What changed
allowed-toolsare told to add a tool that covers the missing capability.permissionsare told to add the missing capability to that list.Why
LP1 currently tells Agent Skills authors to add a generic permission to
SKILL.md, but the Agent Skills schema usesallowed-tools. Following the existing remediation can therefore produce an unsupported field and leave the finding unresolved.PR #316 corrected the same guidance gap for LP3. This completes the remaining LP1 path described in #300 without changing detection, scoring, or schema behavior.
Validation
ruff checkon the changed Python and test filesruff format --checkon the changed Python and test filesgit diff --checkThe focused regression assertions are included; the repository's full dependency-backed test suite is left to GitHub Actions to avoid installing its unrelated AI/AWS runtime stack locally.