Skip to content

fix(lp1): tailor remediation to manifest type - #402

Merged
rng1995 merged 5 commits into
NVIDIA:mainfrom
green3sf:agent/lp1-manifest-remediation
Aug 20, 2026
Merged

rng1995 merged 5 commits into
NVIDIA:mainfrom
green3sf:agent/lp1-manifest-remediation

Conversation

@green3sf

Copy link
Copy Markdown
Contributor

Closes #300.

What changed

  • Make LP1 remediation follow the declaration source:
    • Agent Skills using allowed-tools are told to add a tool that covers the missing capability.
    • MCP server manifests using permissions are told to add the missing capability to that list.
  • Align the LP1 fallback remediation and the B.3.1 design documentation.
  • Add regression assertions for both manifest shapes.

Why

LP1 currently tells Agent Skills authors to add a generic permission to SKILL.md, but the Agent Skills schema uses allowed-tools. Following the existing remediation can therefore produce an unsupported field and leave the finding unresolved.

PR #316 corrected the same guidance gap for LP3. This completes the remaining LP1 path described in #300 without changing detection, scoring, or schema behavior.

Validation

  • ruff check on the changed Python and test files
  • ruff format --check on the changed Python and test files
  • Python AST parsing for the changed Python and test files
  • git diff --check

The focused regression assertions are included; the repository's full dependency-backed test suite is left to GitHub Actions to avoid installing its unrelated AI/AWS runtime stack locally.

Signed-off-by: green3sf <222944370+green3sf@users.noreply.github.com>

@rng1995 rng1995 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[SkillSpector Review]

Approved. LP1 remediation now follows the declaration shape actually in use: Agent Skills receive allowed-tools guidance and MCP manifests receive permissions guidance. The runtime fallback, defaults, documentation, and regressions are aligned; required CI is green.

@rng1995
rng1995 enabled auto-merge (squash) August 20, 2026 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LP1/LP3 remediation points at a permissions field that the Agent Skills spec does not define

2 participants