Skip to content

fix(discovery): report skipped symlinked skills - #499

Open
deepujain wants to merge 1 commit into
NVIDIA:mainfrom
deepujain:fix/495-recursive-symlink-coverage
Open

fix(discovery): report skipped symlinked skills#499
deepujain wants to merge 1 commit into
NVIDIA:mainfrom
deepujain:fix/495-recursive-symlink-coverage

Conversation

@deepujain

Copy link
Copy Markdown
Contributor

Summary

  • report recursive discovery as incomplete when a symlinked child skill is skipped
  • preserve the no-follow policy while preventing a false complete-coverage result

Validation

  • python3 -m py_compile src/skillspector/multi_skill.py - passed
  • python3 -m pytest tests/test_multi_skill.py -k symlinked_skill_directory_marks_discovery_incomplete - unavailable locally because pytest is not installed; GitHub CI will run the focused suite

Risk

  • The change fails closed for recursive discovery and does not follow symlinks.

Fixes #495

Signed-off-by: Deepak Jain <deepujain@gmail.com>
@deepujain
deepujain force-pushed the fix/495-recursive-symlink-coverage branch from 22c726a to 84b41e2 Compare September 9, 2026 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Recursive scan silently skips symlinked skill directories while reporting skills_omitted: 0 and analysis_completeness: complete (100%)

1 participant