fix(baseline): preserve exact findings and protect baseline output - #657
Open
chrisknvidia wants to merge 4 commits into
Open
chrisknvidia wants to merge 4 commits into
chrisknvidia wants to merge 4 commits into
Conversation
Signed-off-by: Christopher Kevin <christopherk@nvidia.com>
Signed-off-by: Christopher Kevin <christopherk@nvidia.com>
chrisknvidia
marked this pull request as ready for review
September 28, 2026 20:36
Signed-off-by: Christopher Kevin <christopherk@nvidia.com>
Signed-off-by: Christopher Kevin <christopherk@nvidia.com>
chrisknvidia
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Baseline generation fingerprinted compacted report representatives, leaving repeated findings and identical matches in other files active on an unchanged rescan. Generate exact fingerprints from sanitized original findings before report compaction, preserving each occurrence's evidence and strict source/version matching.
Reject failed scans before generating acceptance; warn when accepting observed findings from a successful partial scan. Validate the complete baseline before atomic replacement, preserve existing output on failures, and round-trip Unicode reasons correctly. POSIX output is owner-only, with inherited macOS ACLs removed before writing; symlink and special-file destinations are rejected.
Add a dedicated credential-free CI job for real baseline CLI and MCP transport regressions. Isolate the FIFO operation watchdog from cold-import latency and check dense-directory timing against the documented stage deadlines.
Closes #656.
Validation: 620 focused tests, 14 CLI/MCP integration tests, 29 installed-wheel cases and an actual installed-command scan → baseline → rescan (18 findings → 18 suppressed, zero active). Native macOS ACL checks and real provider-failure output preservation also passed. Live semantic evidence can vary between runs; exact matching remains intentionally strict, with the static-only workflow documented.