ci: Validate pull request commit messages#32
Merged
Conversation
Check every non-merge pull request commit for the repository's subject format and 72-column prose limit. Report violations as workflow annotations while preserving recognized Git trailers. Document the policy and cover valid, invalid, boundary, trailer, and merge cases with a dependency-free shell test. Signed-off-by: Nirmoy Das <nirmoyd@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
subsystem: Descriptionsubjects and 72-column prose for non-merge PR commitsWhy
PR #29 needed several commit-message rewrites, and its final approved message still contained a 74-column prose line. A deterministic check makes the policy consistent and keeps review focused on the change itself.
Validation
.github/scripts/test-check-commit-messages.shbash -n .github/scripts/check-commit-messages.sh .github/scripts/test-check-commit-messages.shcargo +stable fmt --all -- --checkcargo +stable test --all-targets --locked(399 tests)