feat(probes): add UTF fullwidth encoding probe#1864
Open
nuthalapativarun wants to merge 1 commit into
Open
Conversation
Signed-off-by: Varun Nuthalapati <nuthalapativarun@gmail.com>
Contributor
Author
|
Investigated the failing Root cause: unrelated infra flake, not caused by this PR's diff. Evidence:
No code changes made — this is a HuggingFace Hub rate-limit / GH Actions cache-miss flake on that one runner, unrelated to the probe implementation. Re-running the job should clear it once the cache is warm again or HF Hub rate limits reset. |
Contributor
Author
|
Just a friendly nudge on this one — CI's been green for a while and it's still mergeable. Happy to make any tweaks if there's feedback. |
Contributor
Author
|
Hi team — following up on PR #1864 (UTF fullwidth encoding probe). CI is green and the PR has been open for ~3 weeks with no review. Happy to address any feedback. Thanks for your time! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
InjectUTFFullwidthprobe togarak/probes/encoding.py, which encodes payloads by mapping ASCII printable characters (0x21-0x7E) to their Unicode fullwidth equivalents (U+FF01-FF5E), following the same pattern as the existingInjectZalgoandInjectLeetprobes.EncodingMixinbase,TEMPLATES, payload mechanism, tags, and detectors used by other encoding probes.Ref #152
AI assistance disclosure
This change was developed with AI assistance (Claude). The implementation follows the existing conventions of
garak/probes/encoding.py(mirroringInjectZalgo/InjectLeet). I reviewed the diff for correctness and style consistency before submitting.Test plan
python -m pytest tests/probes/test_probes_encoding.py -q- 226 passed, 1 skipped (skip is pre-existing/unrelated)python -m pytest tests/probes -q -k encoding- all passing, new probe auto-discovered via existing test enumerationpython -m black garak/probes/encoding.py- no changes needed beyond new code, file formatted