Conversation
bdice
added
improvement
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Define RAFT's resource ref aliases in
raft/mr/host_device_resource.hppdirectly over the CCCL types, following the convention in rapidsai/build-planning#337: plain names are stream-ordered and synchronous refs carry asynchronous_prefix.raft::mr::device_resource_ref(new, replacesrmm::device_async_resource_ref)cuda::mr::resource_ref<cuda::mr::device_accessible>raft::mr::synchronous_host_resource_ref(renamed)cuda::mr::synchronous_resource_ref<cuda::mr::host_accessible>raft::mr::synchronous_host_device_resource_ref(renamed)cuda::mr::synchronous_resource_ref<cuda::mr::host_accessible, cuda::mr::device_accessible>raft::mr::host_resource_refandraft::mr::host_device_resource_refare deprecated. Under the new convention those names will refer to stream-ordered refs, so they can't keep their synchronous meaning. None of cuVS, cuML, cuGraph, cuGraph-GNN, RapidsMPF or cuDF use them.<rmm/resource_ref.hpp>is no longer included from RAFT. The aliases name the same types as before, so the ABI is unchanged.Part of rapidsai/build-planning#337.