Conversation
Allow overriding the `CMAKE_BUILD_TYPE` in the `build.sh` script via environment variables. Mirrors the `LIBRAFT_BUILD_DIR` pattern. This allows, for example, writing `LIBRAFT_BUILD_TYPE=RelWithDebInfo ./build.sh` to build raft with debug symbols and optimization enabled - without modifying the build script.
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: NVIDIA/raft/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review. 📝 SummarySummary by CodeRabbit
WalkthroughThe build script now uses ChangesBuild configuration
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Feature Merge Risk: ⚪ Minimal · up to The environment variable can select the build type for the usual build invocation, while 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3161 +/- ##
=======================================
Coverage 57.64% 57.64%
=======================================
Files 19 19
Lines 517 517
=======================================
Hits 298 298
Misses 219 219 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Allow overriding the
CMAKE_BUILD_TYPEin thebuild.shscript via environment variables.Mirrors the
LIBRAFT_BUILD_DIRpattern.This allows, for example, writing
LIBRAFT_BUILD_TYPE=RelWithDebInfo ./build.shto build raft with debug symbols and optimization enabled - without modifying the build script.