Skip to content

Remove remaining rmm/cuda_stream_view.hpp includes - #3163

Merged
divyegala merged 2 commits into
NVIDIA:mainfrom
bdice:remove-stale-rmm-stream-view-includes
Oct 1, 2026
Merged

divyegala merged 2 commits into
NVIDIA:mainfrom
bdice:remove-stale-rmm-stream-view-includes

Conversation

@bdice

@bdice bdice commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Follow-up to #3129. Replaces the three remaining unused #include <rmm/cuda_stream_view.hpp> with #include <cuda/stream> in headers that only use cuda::stream_ref, and replaces the last rmm::cuda_stream::view() call (in tests/core/interruptible.cu) with the conversion to cuda::stream_ref. These APIs were removed in rapidsai/rmm#2552, so this fixes the build against current rmm nightlies.

@bdice
bdice requested a review from a team as a code owner October 1, 2026 14:33
@bdice bdice added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Oct 1, 2026
@coderabbitai

coderabbitai Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: NVIDIA/raft/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: da243ac7-6c79-492f-8e15-7a7c90966b83

📥 Commits

Reviewing files that changed from the base of the PR and between 5bca062 and 5808c4e.

📒 Files selected for processing (1)
  • cpp/tests/core/interruptible.cu

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 9 remain after this review.


📝 Summary

Summary by CodeRabbit

  • Chores
    • Updated CUDA stream integration across linear algebra, matrix selection, and kernel launches. These changes do not alter the functionality available in those areas or introduce user-facing behavior changes. Existing workflows remain unchanged.

Walkthrough

Three C++ headers replace the RMM CUDA stream-view include with <cuda/stream>. In the interruptible test, capturing_stream::view() returns its stream member directly.

Changes

CUDA stream header updates

Layer / File(s) Summary
CUDA stream API updates
cpp/include/raft/linalg/detail/lstsq.cuh, cpp/include/raft/matrix/detail/select_radix.cuh, cpp/include/raft/util/kernel_launch.hpp, cpp/tests/core/interruptible.cu
The headers include <cuda/stream> instead of <rmm/cuda_stream_view.hpp>. The test returns the rmm::cuda_stream member directly.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Refactor

Suggested reviewers: cjnolet, achirkin

Merge Risk: ⚪ Minimal · up to 5808c

The stream API updates preserve the expected types, with no identified issue blocking merge.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 2 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly and concisely summarizes the main change: removing the remaining rmm/cuda_stream_view.hpp includes.
Description check ✅ Passed The description accurately explains the include replacements and the rmm::cuda_stream::view() update described in the changeset.
  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
🧪 Generate unit tests (beta)
  • Create a new PR
🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Comment @coderabbitai help to get the list of available commands.

@bdice

bdice commented Oct 1, 2026

Copy link
Copy Markdown
Contributor Author

/merge

@divyegala
divyegala merged commit 745da7c into NVIDIA:main Oct 1, 2026
75 of 95 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants