Remove remaining rmm/cuda_stream_view.hpp includes - #3163
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: NVIDIA/raft/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 9 remain after this review. 📝 SummarySummary by CodeRabbit
WalkthroughThree C++ headers replace the RMM CUDA stream-view include with ChangesCUDA stream header updates
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Refactor Suggested reviewers: Merge Risk: ⚪ Minimal · up to The stream API updates preserve the expected types, with no identified issue blocking merge. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1🧪 Generate unit tests (beta)
🛠️ Fix failing CI checks 💡
Comment |
|
/merge |
Follow-up to #3129. Replaces the three remaining unused
#include <rmm/cuda_stream_view.hpp>with#include <cuda/stream>in headers that only usecuda::stream_ref, and replaces the lastrmm::cuda_stream::view()call (intests/core/interruptible.cu) with the conversion tocuda::stream_ref. These APIs were removed in rapidsai/rmm#2552, so this fixes the build against current rmm nightlies.