Skip to content

fix: self.soft_argmax used but never instantiated - #41

Open
andrewwhitecdw wants to merge 1 commit into
NVlabs:masterfrom
andrewwhitecdw:bugfix/network-029fe6c7
Open

fix: self.soft_argmax used but never instantiated#41
andrewwhitecdw wants to merge 1 commit into
NVlabs:masterfrom
andrewwhitecdw:bugfix/network-029fe6c7

Conversation

@andrewwhitecdw

@andrewwhitecdw andrewwhitecdw commented Jul 27, 2026

Copy link
Copy Markdown

Problem

fix: self.soft_argmax used but never instantiated

Fix

Replace:

        # Optimizer is created in a separate call, because this isn't needed unless we're training
        self.optimizer = None

with:

        self.soft_argmax = SoftArgmaxPavlo(self.n_keypoints)

        # Optimizer is created in a separate call, because this isn't needed unless we're training
        self.optimizer = None

Files changed

  • dream/network.py

@andrewwhitecdw
andrewwhitecdw marked this pull request as ready for review August 3, 2026 22:14
@andrewwhitecdw

Copy link
Copy Markdown
Author

Closing this sweep-generated PR: sole commit is missing a valid Signed-off-by trailer. It does not meet the sweep requirements (single signed-off commit).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant