Skip to content

fix: exact equality asserts compare computed floats - #42

Open
andrewwhitecdw wants to merge 1 commit into
NVlabs:masterfrom
andrewwhitecdw:bugfix/oks-plots-18637ffb
Open

fix: exact equality asserts compare computed floats#42
andrewwhitecdw wants to merge 1 commit into
NVlabs:masterfrom
andrewwhitecdw:bugfix/oks-plots-18637ffb

Conversation

@andrewwhitecdw

@andrewwhitecdw andrewwhitecdw commented Jul 27, 2026

Copy link
Copy Markdown

Problem

fix: exact equality asserts compare computed floats

Fix

Replace:

    assert kp_metrics["l2_error_mean_px"] == np.mean(all_dist)
    assert kp_metrics["l2_error_median_px"] == np.median(all_dist)
    assert kp_metrics["l2_error_std_px"] == np.std(all_dist)
    assert np.abs(auc - kp_metrics["l2_error_auc"]) < 1.0e-15

with:

    assert np.abs(kp_metrics["l2_error_mean_px"] - np.mean(all_dist)) < 1.0e-9
    assert np.abs(kp_metrics["l2_error_median_px"] - np.median(all_dist)) < 1.0e-9
    assert np.abs(kp_metrics["l2_error_std_px"] - np.std(all_dist)) < 1.0e-9
    assert np.abs(auc - kp_metrics["l2_error_auc"]) < 1.0e-15

Files changed

  • dream/oks_plots.py

@andrewwhitecdw
andrewwhitecdw marked this pull request as ready for review August 3, 2026 22:14
@andrewwhitecdw

Copy link
Copy Markdown
Author

Closing this sweep-generated PR: sole commit is missing a valid Signed-off-by trailer. It does not meet the sweep requirements (single signed-off commit).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant