fix(tma): select CTA-local G2S on SM120/SM121 - #1249
Open
lucifer1004 wants to merge 1 commit into
Open
lucifer1004 wants to merge 1 commit into
lucifer1004 wants to merge 1 commit into
Conversation
Signed-off-by: Zihua Wu <13583761+lucifer1004@users.noreply.github.com>
This was referenced Sep 7, 2026
nihalpasham
requested changes
Sep 15, 2026
nihalpasham
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed 5620feea: changes requested.
- The local path removes the compatibility call and retains register reallocation; rank/target controls and local GPU memory/synchronization checks pass.
- The existing API permits cluster-shared destinations. A GPU target alone does not prove that both destination and barrier belong to the executing CTA (thread block).
same GPU target:
local destination + barrier -> CTA form is valid
peer-CTA destination -> preserve the cluster contract
- Establish locality or introduce an explicit local API. Checking only explicitly cluster-typed pointers misses generic pointers across helper calls. Cover both operands and preserve existing cluster behavior.
- Rebase and sign the revision.
#1238 remains partial.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Select CTA-local TMA global-to-shared loads on SM120/SM121, including their
aandftargets. For local destinations, this avoids the compatibility call that conflicts with register reallocation. Partially addresses #1238.Shape of the change
Validation
Remaining work
The existing API permits cluster-shared memory. A GPU target alone does not prove that the destination and barrier belong to the executing CTA (thread block), and a helper call can carry these addresses through a generic pointer.
Prove locality for both operands or expose an explicit local API while preserving the cluster contract. The successful local controls do not resolve this API gap.