feat: add NodeHelloResponse model - #36
Merged
NeonDaniel merged 1 commit intoAug 4, 2026
Merged
Conversation
Hub acknowledgement of a `node.hello`, per review discussion on neon-hana#58: success carries the hub-normalized snapshot (session- derived node_id, cached name and capabilities -- what `context.node` will carry), rejection carries the validation error that made the hub drop the hello. Without the ack, a rejected hello is invisible to the Node and capability gating silently does nothing. `status`/`error` mirror NodeInvokeNativeResponse, including the model_validator coupling status to the presence of `node`/`error`.
NeonDaniel
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the model for
node.hello.response, the hub's acknowledgement of anode.hello— proposed in review onNeonGeckoCom/neon-hana#58and implemented there (hub) and inOscillateLabsLLC/neon-node-flutter-app(node).Shape
{"status": "success", "node": {node_id, node_name, capabilities}}— the hub-normalized snapshot as cached, i.e. whatcontext.nodewill carry (session-derivednode_id, not the client-claimed one){"status": "error", "error": {"message": <validation error>}}status/errormirrorNodeInvokeNativeResponse, including themodel_validatorcouplingstatusto the presence ofnode/error. Hubs that predate the ack simply never send one, which is what lets a Node flag an outdated hub.Why
Without the ack, a rejected
node.hellois invisible to the Node: the hub logs a WARNING and everything downstream behaves as though the Node advertised nothing. We hit exactly this on-device — a missingnode_idmeant every hello was silently dropped and capability gating did nothing, with no error on either side.Tests
test_node_hello_responsein the existing style: success snapshot, wire-string capability round-trip, rejection message, and the three invalid status/field combinations. 157 pass locally.Follow-ups once released
neon-hana#58can construct the ack via this model (currently a hand-builtMessagewith the same shape)node_v1_docunions can gain the new type🤖 Generated with Claude Code