Quiet non-actionable startup warnings & status in progress bar - #1628
Open
dxqb wants to merge 6 commits into
Open
Quiet non-actionable startup warnings & status in progress bar#1628dxqb wants to merge 6 commits into
dxqb wants to merge 6 commits into
Conversation
Suppress a handful of specific, noisy-but-harmless messages emitted while launching the UI and starting training: - diffusers/transformers logger.warning() lines (Modular Diffusers experimental notice, unexpected-config-attributes, unrecognized loss_type) via filters on the exact emitting loggers - huggingface_hub local_dir_use_symlinks deprecation and the torch.compile inductor performance notes via warnings/logger filters - Qt gnome portal dbus errors via QT_LOGGING_RULES - tensorboard subprocess banner/notices by discarding its stdout/stderr Each filter targets one specific message, so other warnings from the same libraries still come through. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
# Conflicts: # modules/util/ui/pyside6_util.py
A cold torch.compile cache announces every frame it compiles, which scrolls the progress bar off the screen. There is no knowable total to build a real progress bar from, so the announcement goes into the postfix of the innermost running bar instead, and is cleared again by that bar's next redraw or by its close. tqdm keeps its bars in an unordered WeakSet, so which of the nested bars is the innermost one cannot be recovered from it. modules/util/tqdm_util.py subclasses tqdm to track that itself and adds show_status() next to tqdm.write(); every tqdm import in the repo now comes from there. Bars owned by mgds are outside this and still draw as before. Also gates the warning filters on OT_DEBUG_WARNINGS, so setting it brings every suppressed message back, and silences the diffusers attention-backend experimental notice. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
dxqb
changed the title
Collaborator
Author
|
now also shows the torch.compile progress in the tqdm bar, to avoid message flooding |
This was referenced Aug 9, 2026
Upstream diffusers removed the warning itself, so the filter has nothing left to match. It still fires on the diffusers commit pinned in requirements-global.txt, which predates that removal, until the pin is bumped. Also picks up master, which had landed the profiler-steps and mxfp8 changes this branch was still showing as removals. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Advances the merge base so the diff shows only this branch's own work again, instead of the commits that have since landed upstream.
Brings the branch up to master's tip, so the diff no longer reverts the commits that have landed upstream since.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Suppress a handful of specific, noisy-but-harmless messages emitted while launching the UI and starting training:
Each filter targets one specific message, so other warnings from the same libraries still come through.
Test plan
pre-commit run --all-filespassesAI assistance