cnid: sqlite-default residual cleanup; dsi: raise the listen backlog to 128

.github/workflows/containers.yml

@@ -478,6 +478,7 @@ jobs:
               -e AFP_DIRCACHE_RFORK_BUDGET=1048576 \
               -e AFP_DIRCACHE_RFORK_MAXSIZE=1024 \
               -e AFP_CONVERT_APPLEDOUBLE=no \
+              -e AFP_CNID_BACKEND=dbd \
               ${{ env.REGISTRY }}/netatalk/netatalk:${{ github.sha }}
       - name: Run Netatalk testsuite
         run: |

NEWS.md

@@ -4,6 +4,14 @@ Netatalk Changelog
 Changes in 4.6.0
 ----------------
 
+* UPD: dsi: listen backlog raised from 20 to 128, absorbing reconnect
+  storms without dropped SYNs (the kernel still caps it at
+  net.core.somaxconn), GitHub #3267
+* UPD: cnid: the default CNID scheme has changed to *sqlite*: the build
+  system now selects sqlite > mysql > dbd among the compiled backends
+  (GitHub #3077), and the docker image's fallback for an unset
+  AFP_CNID_BACKEND now matches. The dbd backend remains available but is
+  deprecated, GitHub #3267
 * UPD: netatalk: cnid_metad is now started only when a volume uses the
   dbd CNID scheme, and started or stopped on config reload as volumes
   change; previously it always ran when the dbd backend was compiled in,

distrib/docker/env_setup_netatalk.sh

@@ -629,7 +629,7 @@ vol charset = ${AFP_VOL_CHARSET:-UTF8}
 spotlight = $AFP_SPOTLIGHT_GLOBAL
 spotlight backend = ${AFP_SPOTLIGHT_BACKEND:-cnid}
 [${SHARE_NAME:-File Sharing}]
-cnid scheme = ${AFP_CNID_BACKEND:-dbd}
+cnid scheme = ${AFP_CNID_BACKEND:-sqlite}
 ea = $AFP_EA
 path = $NETATALK_SHARE_DIR
 valid users = $AFP_VALIDUSERS1
@@ -638,7 +638,7 @@ $AFP_RWRO = $AFP_VALIDUSERS1
 convert appledouble = ${AFP_CONVERT_APPLEDOUBLE:-no}
 spotlight = $AFP_SPOTLIGHT_GLOBAL
 [${SHARE_NAME2:-Time Machine}]
-cnid scheme = ${AFP_CNID_BACKEND:-dbd}
+cnid scheme = ${AFP_CNID_BACKEND:-sqlite}
 ea = $AFP_EA
 path = $NETATALK_BACKUP_DIR
 time machine = $TIMEMACHINE

doc/manpages/man5/afp.conf.5.md

@@ -525,6 +525,7 @@ Requires datbase administration, giving you full control over how the CNID data
 >
 > *sqlite*: uses the SQLite embedded database library.
 It is performant and lean, requiring no external database or daemon.
+This is the default backend when compiled in.
 
 cnid server = *host[:port]* **(G)**/**(V)**
 

libatalk/dsi/dsi_tcp.c

@@ -48,7 +48,7 @@ int deny_severity = log_warning;
 #define min(a,b)  ((a) < (b) ? (a) : (b))
 
 #ifndef DSI_TCPMAXPEND
-#define DSI_TCPMAXPEND      20       /*!< max # of pending connections */
+#define DSI_TCPMAXPEND      128      /*!< max # of pending connections */
 #endif /* DSI_TCPMAXPEND */
 
 #ifndef DSI_TCPTIMEOUT