Skip to content

Only allow reusable ByteBuffers when not compressing. #1141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattl-netflix merged 1 commit into from
Jun 1, 2026
Merged

Only allow reusable ByteBuffers when not compressing. #1141

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions priam/src/main/java/com/netflix/priam/aws/S3FileSystem.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ private Map<String, String> getFileMetadata(File file) {

private long uploadMultipart(AbstractBackupPath path, Instant target)
throws BackupRestoreException {
if (config.useReusableBufferForMultipartUploads()) {
if (config.useReusableBufferForMultipartUploads() && path.getCompression() == CompressionType.NONE) {
return uploadMultipartWithBuffers(path, target);
} else {
return uploadMultipartLegacy(path, target);
Expand Down Expand Up @@ -355,7 +355,7 @@ protected long uploadFileImpl(AbstractBackupPath path, Instant target)
if (localFile.length() >= config.getBackupChunkSize())
return uploadMultipart(path, target);

if (config.useReusableBufferForMultipartUploads()) {
if (config.useReusableBufferForMultipartUploads() && path.getCompression() == CompressionType.NONE) {
return uploadFileWithByteBuffer(path, target);
} else {
return uploadFileWithByteArray(path, target);
Expand Down