Repository navigation
feature: Implement alias db lookups - #712
Merged
Merged
Conversation
gabeiglio
force-pushed
the
feature/aliases
branch
4 times, most recently
from
August 17, 2026 14:13
41c686d to
fa1bbb5
Compare
bryanck
reviewed
Aug 18, 2026
| ); | ||
|
|
||
| CREATE TABLE ALIASES ( | ||
| id UUID DEFAULT uuid_generate_v4() NOT NULL PRIMARY KEY, |
Collaborator
There was a problem hiding this comment.
Seems like we aren't consistent in using uuid_generate_v4 vs gen_random_uuid, but that's preexisting
bryanck
reviewed
Aug 18, 2026
bryanck
reviewed
Aug 18, 2026
| -Dmetacat.definition.metadata.delete.enableDeleteForQualifiedNames=hive-metastore/hsmoke_ddb,hive-metastore/hsmoke_ddb1/test_create_table1,embedded-hive-metastore,embedded-fast-hive-metastore/fsmoke_db1,embedded-fast-hive-metastore/fsmoke_ddb1,embedded-fast-hive-metastore/shard,embedded-fast-hive-metastore/fsmoke_db4,s3-mysql-db,mysql-56-db | ||
| -Dmetacat.hive.metastore.batchSize=10 | ||
| -Dmetacat.hive.iceberg.enabled=true | ||
| -Dmetacat.alias-service-properties.enabled=true |
Collaborator
There was a problem hiding this comment.
maybe just aliases instead of alias-service-properties
bryanck
reviewed
Aug 18, 2026
bryanck
reviewed
Aug 18, 2026
Collaborator
|
LGTM, just some nits |
bryanck
approved these changes
Aug 18, 2026
gabeiglio
force-pushed
the
feature/aliases
branch
from
August 20, 2026 16:32
277b6d0 to
7609e3a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.