Skip to content

temp fix: midi numbers are now only positive values #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
samankittani merged 1 commit into from
May 4, 2026
Merged

temp fix: midi numbers are now only positive values #98

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions extensions/BeatBlox/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -410,7 +410,7 @@
let tt = 0;
for (let j = 0; j < duration[i].length; ++j) {
const m = j === duration[i].length - 1 ? mods : mods.concat([ audio.getModification(MODIFIERS['Tie']) ]);
tt += await audio.playNote(this.receiver.id, notes[i], this.musicInfo.t + tt, DURATIONS[duration[i][j]], m);
tt += await audio.playNote(this.receiver.id, -1 * Math.abs(notes[i]), this.musicInfo.t + tt, DURATIONS[duration[i][j]], m);
}
t = Math.min(t, tt);
}
Expand Down Expand Up @@ -480,15 +480,15 @@
}
}),
new Extension.Block('tieDuration', 'reporter', 'music', 'tie %mult%noteDuration', [['Quarter']], durations => durations.contents.map(x => x.toString()).filter(x => x.length !== 0).join('+')),
new Extension.Block('noteNumber', 'reporter', 'music', 'note# %s', ['C4'], note => snapify(parseNote(note))),
new Extension.Block('noteNumber', 'reporter', 'music', 'note# %s', ['C4'], note => snapify(Math.abs(parseNote(note)))),
new Extension.Block('chordNotes', 'reporter', 'music', '%s %chordType chord', ['C4', 'Major'], function (note, type) {
if (CHORD_PATTERNS[type] === undefined) throw Error(`unknown chord type: '${type}'`);
function f(b) { return b.map ? b.map(f) : CHORD_PATTERNS[type].map(x => -(x + Math.abs(b))); }
function f(b) { return b.map ? b.map(f) : CHORD_PATTERNS[type].map(x => (x + Math.abs(b))); }
return snapify(f(parseNote(note)));
}),
new Extension.Block('scaleNotes', 'reporter', 'music', '%s %scaleType scale', ['C4', 'Major'], function (note, type) {
if (SCALE_PATTERNS[type] === undefined) throw Error(`unknown scale type: '${type}'`);
function f(b) { return b.map ? b.map(f) : SCALE_PATTERNS[type].map(x => -(x + Math.abs(b))); }
function f(b) { return b.map ? b.map(f) : SCALE_PATTERNS[type].map(x => (x + Math.abs(b))); }
return snapify(f(parseNote(note)));
}),
new Extension.Block('playClip', 'command', 'music', 'play sound %snd', [], function (rawSound) {
Expand Down
Loading