chore(e2e): simplify testkit copy + stream relay-button-chat progress - #5
Open
NiKrause wants to merge 1 commit into
Open
chore(e2e): simplify testkit copy + stream relay-button-chat progress#5NiKrause wants to merge 1 commit into
NiKrause wants to merge 1 commit into
Conversation
The @le-space/playwright testkit now builds self-contained (--no-splitting in 0.6.34), so both E2E workflows can copy a single dist/index.js instead of mirroring the whole dist tree with a synthetic package.json — drop the chunk-copy workaround in js-peer-relay-button-e2e.yml and js-peer-remote-replication.yml. Adopt the testkit's logging helpers in relay-button-chat.spec.ts so the run is no longer silent for minutes: forward each browser's libp2p console into the test log via forwardBrowserConsole, and emit timestamped stage markers (provisioning, opening-browsers, connecting-relay, plus every evidence step) through createProgressLogger. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consumer follow-ups now that the shared
@le-space/playwrighttestkit (relay-button 0.6.34) ships the fixes it needed.What & why
1. Drop the testkit chunk-copy workaround (both E2E workflows)
build:publishis now self-contained (--no-splitting), so a singlecp .../dist/index.js …/index.mjsreplaces the previous "mirror the whole dist tree + synthetic{"type":"module"}" hack that worked around tsup code-splitting (Cannot find module chunk-*.js)..github/workflows/js-peer-relay-button-e2e.yml.github/workflows/js-peer-remote-replication.yml2. Make
relay-button-chat.spec.tsdiagnosable instead of silentThe relay-button chat E2E previously ran for minutes with no output. It now uses the testkit's logging helpers:
forwardBrowserConsole(page, { label })per browser → each browser's libp2p connection/discovery console lines stream into the test log.createProgressLogger({ label: 'relay-chat' })→ timestamped stage markers (provisioning,opening-browsers,connecting-relay, and every evidence step viapass()), matching simple-todo's[remote-e2e] stage: …format.Scope notes
libp2p.tsprofiletype lag (installed@le-space/aleph-bootstrappredates the type field added in fix(relay): scope Aleph relay discovery to the uc-go-peer profile #3) is untouched here — it resolves at runtime and is out of scope for this PR.🤖 Generated with Claude Code