Active slide event - #266
Open
v-matheusb wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the
glider-slide-activeevent to solve an issue where I discovered when making this type of slider:It's composed of 2 sliders and I sync them by updating the current slider index during the
glider-slide-visibleevent. I needed the centered slide to be active and adjacent ones to show partially, but I found that in some screen sizes, the event was triggering for one of the adjacent slides, which made it skip one slide in some cases, as well as sometimes causingglider-slide-visibleto trigger multiple times while scrolling to a slide.My solution was to create the
glider-slide-activeand made sure that it would only trigger once per slide scroll.