Add resize observer to refresh when visibilty changes - #277
Open
OMGPizzaGuy wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In cases were the gilder starts hidden and is shown by user action, the dots will not recalculate and arrows will not function if slidesToShow is 'auto' as that value will calculate to zero.
This might happen if the glider is placed inside a drawer or accordion component.
If the glider is set to be responsive, a ResizeObserver can be used to detect show / hide, reset the breakpoint, and refresh the glider.
Fix for #276
This is low priority as code can be added outside glider.js to workaround the issue