serokell-nix: drop dependency#406
Conversation
We recently upgraded our npins schema and upgraded nixpkgs. I didn't consider that pulling the latest nixpkgs would cause us to pull a newer version of npins with an even newer schema. So here we go! To generate this, I ran `npins upgrade`, which told me to run `npins update --partial` (which had no effect).
This fixes NixOS#405 Many thanks for Serokell for starting and donating this project!
| }; | ||
| hlint = pkgs.build.haskell.hlint haskellSource; | ||
| hlint = | ||
| pkgs.runCommand "hlint" |
There was a problem hiding this comment.
Is this trivial* enough to justify runCommandLocal?
*and/or fast and/or unique
There was a problem hiding this comment.
I don't know :(. I personally don't like making these decisions, I'd rather nix have its own heuristics for this sort of stuff.
There was a problem hiding this comment.
I'm going to merge this as is, but feel free to change it if you want!
There was a problem hiding this comment.
runCommandLocal (or passing runLocal = true to runCommandWith) configures preferLocalBuild and allowSubstitutes to instruct nix to skip network requests for remote builders and binary substituters (runCommandWith impl).
Rule of thumb: if the buildscript runs a command that you wouldn't think twice about running locally, because it if fairly quick, then it is probably better to use runCommandLocal to avoid waiting for network requests to binary substituters and remote builders.
Alternatively, if the derivation's inputs (e.g. source files) change so often that it is unlikely there will be a binary cache available, then it may be worth considering runCommandLocal.
2 participants
This fixes #405
Many thanks for Serokell for starting and donating this project!