Skip to content

nixos/cosmic: use oo7 for Secret portal - #539086

Closed
caniko wants to merge 1 commit into
NixOS:masterfrom
caniko:codex/cosmic-oo7-secret-service
Closed

nixos/cosmic: use oo7 for Secret portal#539086
caniko wants to merge 1 commit into
NixOS:masterfrom
caniko:codex/cosmic-oo7-secret-service

Conversation

@caniko

@caniko caniko commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Switch COSMIC to the Secret Service backend preferred by upstream COSMIC portal routing: oo7-portal first, with oo7-server available for user D-Bus activation. This keeps xdg-desktop-portal-gtk because upstream COSMIC still declares default=cosmic;gtk;.

GNOME keyring now defaults off for COSMIC, but users can temporarily opt back in with services.gnome.gnome-keyring.enable = true if they need access to old keyrings. Existing GNOME keyring data is preserved in place and is not automatically migrated.

nixpkgs-review-gha is running: https://github.com/caniko/nixpkgs-review-gha/actions/runs/28826584841

Generated with assistance from OpenAI Codex (GPT-5); reviewed before submission.

Things done

Assisted-by: OpenAI Codex (GPT-5)
@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. labels Jul 6, 2026
@caniko

caniko commented Jul 6, 2026

Copy link
Copy Markdown
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 539086
Commit: 06c8448645eedab806523d2dbd6a0f184a8d897d (subsequent changes)
Merge: 47777458324c38da53c3c81c4d40a135c3f3e47b

Logs: https://github.com/caniko/nixpkgs-review-gha/actions/runs/28826584841


x86_64-linux

⏩ 2 packages blacklisted:
  • nixos-install-tools
  • tests.nixos-functions.nixos-test

aarch64-linux

⏩ 2 packages blacklisted:
  • nixos-install-tools
  • tests.nixos-functions.nixos-test

x86_64-darwin

No rebuilds


aarch64-darwin

No rebuilds

@nixpkgs-ci nixpkgs-ci Bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog This PR adds or changes release notes 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: COSMIC COSMIC is a software platform for designing beautiful user experiences 8.has: documentation This PR adds or changes documentation labels Jul 6, 2026
@caniko
caniko marked this pull request as ready for review July 7, 2026 08:13
@nixpkgs-ci
nixpkgs-ci Bot requested a review from a team July 7, 2026 08:50
services.gnome.gnome-keyring.enable = lib.mkDefault true;
# COSMIC's upstream portal config prefers oo7-portal for
# org.freedesktop.impl.portal.Secret, with gnome-keyring only as fallback.
services.gnome.gnome-keyring.enable = lib.mkDefault false;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Let's keep gnome-keyring enabled until 26.11 goes EoL. I'd prefer lib.mkDefault (lib.versionAtLeast lib.version "27.05").
  2. When gnome-keyring is enabled, lets display a warning that it will be disabled in 26.11 and that one should migrate to OO7 at their earliest convenience.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think gnome keyring being deprecated now and then turned off on 26.11 would be fine though.

@thefossguy

Copy link
Copy Markdown
Member

Totally optional but can you think of any tests related to OO7 that we can add to <nixpkgs/nixos/tests/cosmic/>?

@Pandapip1 Pandapip1 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be predicated on stateVersion IMO

@nyabinary

Copy link
Copy Markdown
Contributor

This should be predicated on stateVersion IMO

Perhaps only disabling gnome keyring should be predicated on stateVersion as opposed to this change altogether.

@Pandapip1

Pandapip1 commented Jul 7, 2026

Copy link
Copy Markdown
Member

Perhaps only disabling gnome keyring should be predicated on stateVersion as opposed to this change altogether.

IIUC only one service can bind to the secret service dbus path at any time, so that would race

@caniko

caniko commented Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

Totally optional but can you think of any tests related to OO7 that we can add to <nixpkgs/nixos/tests/cosmic/>?

We could, but only if there is a testing gap introduced by nixos abstractions. I'd prefer to leave the testing to upstream.

Does gnomeKeyring have any tests?

@HeitorAugustoLN

Copy link
Copy Markdown
Member

Existing GNOME keyring data is preserved in place and is not automatically migrated.

Isn't oo7 a drop-in replacement for gnome-keyring? I am pretty sure GNOME 51 Alpha is already using it

@HeitorAugustoLN

Copy link
Copy Markdown
Member

This PR should also be built upon #526624 ideally

@Pandapip1

Copy link
Copy Markdown
Member

Isn't oo7 a drop-in replacement for gnome-keyring? I am pretty sure GNOME 51 Alpha is already using it

If that's the case (and only if that's the case), then it doesn't need stateVersion.

@caniko

caniko commented Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

P1 fixes:

  • custom_node_path FileNotFoundError under systemd: regenerated use-writable-runtime-paths.patch against the 0.27.0 base. The --base-directory default now falls back to /var/lib/comfyui when both XDG_DATA_HOME and HOME are unset, so systemd units without User= no longer produce /.local/share/comfyui/custom_nodes.

  • PYTHONPATH pollution: added --unset NIX_PYTHONPATH --unset PYTHONPATH to the makeBinaryWrapper call.

  • comfy-aimdo aimdo.so loading: added addDriverRunpath postFixup so CUDA shared libraries are found at runtime.

Build fixes (0.27.0 migration):

  • Added missing comfyui-workflow-templates-json and comfyui-workflow-templates-media-assets-01 to comfyui-workflow-templates dependencies (these are new subpackages in the 0.27.0 release).

  • Fixed hash for comfyui-workflow-templates-json 0.1.1 and comfyui-workflow-templates-media-assets-01 0.1.0 (SRI values were stale from the version bump).

@nyabinary

Copy link
Copy Markdown
Contributor

GNOME 51 Alpha

image Well GNOME switched to it so I assume its the case https://download.gnome.org/sources/gnome-build-meta/51/gnome-build-meta-51.alpha.news

@nyabinary nyabinary mentioned this pull request Jul 9, 2026
14 tasks
@Pandapip1

Copy link
Copy Markdown
Member

Then fair enough, this doesn't need a stateVersion gate

@Pandapip1 Pandapip1 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Empty comment to dismiss stale request changes review

@Pandapip1 Pandapip1 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually yeah, this just looks fine given that

@nyabinary

Copy link
Copy Markdown
Contributor

Closed in favor of #539810

@caniko

caniko commented Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

@nyabinary, I am not sure how best to proceed here.

For transparency, my workflow is a mix of AI-assisted coding, AI-assisted engineering, and traditional manual work. I do make mistakes sometimes, as you have observed, and I am trying to handle those responsibly.

That said, I would like to avoid turning this into a tempest in a teapot. My understanding is that contributors are expected to follow the nixpkgs AI policies, and I believe I am doing that. If there are specific policy violations or concrete quality issues in this PR, I am happy to address them directly.

However, I do not think disliking my workflow is, by itself, a sufficient reason to shut down my PRs. If maintainers are going to block contributions on the basis of AI-assisted work, I think that needs to be enforced through clear policy and consistent process, not personal preference.

Could you point me to the appropriate place to raise this formally? I would like to either file a complaint, or open a broader discussion about how the AI policy is being interpreted and enforced in nixpkgs.

@DaRacci

DaRacci commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

@caniko I think the reason this was closed was due to your seemingly blind usage of AI without any proper testing, and the fact you have a history of doing this.

As provided in that comment from nyabinary, the comments you post in replies to real humans are completely AI generated which frankly is despicable in my view, at the very least i would expect you to have an AI assist you in your reasoning and troubleshooting but when speaking to another person it comes off as dismissive to use a fully AI-generated response without putting your own voice into it.

And expanding on your insistence that you were following the NixOS AI guidelines, in some of your other clearly AI submitted pull requests, there is no notice of it being the work of an AI; You also consistently seem to not bother checking the work the AI is completing for you before submitting it for another person to waste their time sifting your shit.

I am a fairly large user of AI, I have recently started to have it spearhead some projects for me to get them off the floor but the amount of work I have as a reviewer and tester for those is not insignificant.

In summary this is already clearly stated in the guidelines for AI assisted contributions, which it seems you have clearly not read or have disregarded.

Every contribution to Nixpkgs and related development venues, including code, documentation, and communication on GitHub and Matrix, must have a responsible person in the loop who is accountable for that contribution and reviews it before submission, and must transparently disclose any non‐trivial use of automation to produce it, including but not limited to LLM‐based AI tools.

@caniko

caniko commented Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

@DaRacci, I really want to work with you on this to get my reputation restored.

I believe there is unfair treatment, and I have the following points I would like to raise:

  • My past work where it may have been interpreted as "blind" use of AI was before I was made aware of the AI policies, getting used to this decorum has taken some time for me, but I believe I have acclimated. Most of my PRs have a positive impact on the community.
  • No communication was made by any maintainer before shutting down this PR, I also partook in every discussion raised in this PR using emojis and text where I saw fit.
  • No real evidence where this PR violates the policy have been produced.
  • nixos/cosmic: migrate from gnome-keyring to oo7 #539810 is marked as ready, yet I have already found breaking bugs. This PR works on my machine, and another test-flake nixos. I fail to see the discrepancy in quality, and need for transferring to another PR.

I expect us to produce some level of humanity when shutting down each other's work, I can't see that here.

@DaRacci

DaRacci commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

@caniko I think i speak in general for the maintainers, but we are more than happy to have you contribute, just without causing burdens or undue work for others.

My issues I've risen about your pull requests is largely because of the burden on others to validate your work; If you properly validate and test your AI assistants outputs, and follow the policies, I don't think anyone will have an issue.

I also understand and agree that the closing without any communication was probably a bit preemptive, nor does this PR violate the policy; However I also agree that instead of working on this fresh PR we should of been building off the existing one that this was closed in favour for.

If you've found issues with the new PR happy to have you take part in reviewing it and adding feedback.

@caniko

caniko commented Jul 10, 2026

Copy link
Copy Markdown
Contributor Author

@DaRacci, I appreciate it, and I can empathize with the frustration that led us here! Let us move forward, have a nice Friday and weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: COSMIC COSMIC is a software platform for designing beautiful user experiences 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog This PR adds or changes release notes 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

6 participants