nixos/cosmic: use oo7 for Secret portal - #539086
Conversation
Assisted-by: OpenAI Codex (GPT-5)
|
| services.gnome.gnome-keyring.enable = lib.mkDefault true; | ||
| # COSMIC's upstream portal config prefers oo7-portal for | ||
| # org.freedesktop.impl.portal.Secret, with gnome-keyring only as fallback. | ||
| services.gnome.gnome-keyring.enable = lib.mkDefault false; |
There was a problem hiding this comment.
- Let's keep gnome-keyring enabled until 26.11 goes EoL. I'd prefer
lib.mkDefault (lib.versionAtLeast lib.version "27.05"). - When gnome-keyring is enabled, lets display a warning that it will be disabled in 26.11 and that one should migrate to OO7 at their earliest convenience.
There was a problem hiding this comment.
I think gnome keyring being deprecated now and then turned off on 26.11 would be fine though.
|
Totally optional but can you think of any tests related to OO7 that we can add to |
Pandapip1
left a comment
There was a problem hiding this comment.
This should be predicated on stateVersion IMO
Perhaps only disabling gnome keyring should be predicated on stateVersion as opposed to this change altogether. |
IIUC only one service can bind to the secret service dbus path at any time, so that would race |
We could, but only if there is a testing gap introduced by nixos abstractions. I'd prefer to leave the testing to upstream. Does gnomeKeyring have any tests? |
Isn't oo7 a drop-in replacement for gnome-keyring? I am pretty sure GNOME 51 Alpha is already using it |
|
This PR should also be built upon #526624 ideally |
If that's the case (and only if that's the case), then it doesn't need |
|
P1 fixes:
Build fixes (0.27.0 migration):
|
|
Then fair enough, this doesn't need a |
Pandapip1
left a comment
There was a problem hiding this comment.
Empty comment to dismiss stale request changes review
Pandapip1
left a comment
There was a problem hiding this comment.
Actually yeah, this just looks fine given that
|
Closed in favor of #539810 |
|
@nyabinary, I am not sure how best to proceed here. For transparency, my workflow is a mix of AI-assisted coding, AI-assisted engineering, and traditional manual work. I do make mistakes sometimes, as you have observed, and I am trying to handle those responsibly. That said, I would like to avoid turning this into a tempest in a teapot. My understanding is that contributors are expected to follow the nixpkgs AI policies, and I believe I am doing that. If there are specific policy violations or concrete quality issues in this PR, I am happy to address them directly. However, I do not think disliking my workflow is, by itself, a sufficient reason to shut down my PRs. If maintainers are going to block contributions on the basis of AI-assisted work, I think that needs to be enforced through clear policy and consistent process, not personal preference. Could you point me to the appropriate place to raise this formally? I would like to either file a complaint, or open a broader discussion about how the AI policy is being interpreted and enforced in nixpkgs. |
|
@caniko I think the reason this was closed was due to your seemingly blind usage of AI without any proper testing, and the fact you have a history of doing this. As provided in that comment from nyabinary, the comments you post in replies to real humans are completely AI generated which frankly is despicable in my view, at the very least i would expect you to have an AI assist you in your reasoning and troubleshooting but when speaking to another person it comes off as dismissive to use a fully AI-generated response without putting your own voice into it. And expanding on your insistence that you were following the NixOS AI guidelines, in some of your other clearly AI submitted pull requests, there is no notice of it being the work of an AI; You also consistently seem to not bother checking the work the AI is completing for you before submitting it for another person to waste their time sifting your shit. I am a fairly large user of AI, I have recently started to have it spearhead some projects for me to get them off the floor but the amount of work I have as a reviewer and tester for those is not insignificant. In summary this is already clearly stated in the guidelines for AI assisted contributions, which it seems you have clearly not read or have disregarded.
|
|
@DaRacci, I really want to work with you on this to get my reputation restored. I believe there is unfair treatment, and I have the following points I would like to raise:
I expect us to produce some level of humanity when shutting down each other's work, I can't see that here. |
|
@caniko I think i speak in general for the maintainers, but we are more than happy to have you contribute, just without causing burdens or undue work for others. My issues I've risen about your pull requests is largely because of the burden on others to validate your work; If you properly validate and test your AI assistants outputs, and follow the policies, I don't think anyone will have an issue. I also understand and agree that the closing without any communication was probably a bit preemptive, nor does this PR violate the policy; However I also agree that instead of working on this fresh PR we should of been building off the existing one that this was closed in favour for. If you've found issues with the new PR happy to have you take part in reviewing it and adding feedback. |
|
@DaRacci, I appreciate it, and I can empathize with the frustration that led us here! Let us move forward, have a nice Friday and weekend. |

Switch COSMIC to the Secret Service backend preferred by upstream COSMIC portal routing:
oo7-portalfirst, withoo7-serveravailable for user D-Bus activation. This keepsxdg-desktop-portal-gtkbecause upstream COSMIC still declaresdefault=cosmic;gtk;.GNOME keyring now defaults off for COSMIC, but users can temporarily opt back in with
services.gnome.gnome-keyring.enable = trueif they need access to old keyrings. Existing GNOME keyring data is preserved in place and is not automatically migrated.nixpkgs-review-ghais running: https://github.com/caniko/nixpkgs-review-gha/actions/runs/28826584841Generated with assistance from OpenAI Codex (GPT-5); reviewed before submission.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.