Skip to content

nixos/oo7: install oo7-cli and refactor module layout - #540535

Merged
HeitorAugustoLN merged 2 commits into
NixOS:masterfrom
HeitorAugustoLN:oo7-module-package
Jul 11, 2026
Merged

nixos/oo7: install oo7-cli and refactor module layout#540535
HeitorAugustoLN merged 2 commits into
NixOS:masterfrom
HeitorAugustoLN:oo7-module-package

Conversation

@HeitorAugustoLN

Copy link
Copy Markdown
Member

Follow-up to #526624, installs oo7-cli that was missing. I also refactored the module layout to make it easier to look at
cc: @salva09

Things done

@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Jul 10, 2026

@DaRacci DaRacci left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Is there a standard of using attribute nesting instead of the full dot path declarations, or is that normally left more up to the maintainer ?

@nixpkgs-ci nixpkgs-ci Bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jul 11, 2026
@HeitorAugustoLN

Copy link
Copy Markdown
Member Author

Is there a standard of using attribute nesting instead of the full dot path declarations, or is that normally left more up to the maintainer?

I don't think there is, I personally find it more readable

@HeitorAugustoLN
HeitorAugustoLN added this pull request to the merge queue Jul 11, 2026
@nixpkgs-ci nixpkgs-ci Bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Jul 11, 2026
Merged via the queue into NixOS:master with commit ae6979c Jul 11, 2026
33 checks passed
@HeitorAugustoLN
HeitorAugustoLN deleted the oo7-module-package branch July 11, 2026 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants