Refactor peer permissions firewall ruleset#1835
Open
lcruz99 wants to merge 1 commit into
Open
Conversation
Build the per-permission peer whitelists in a single pass over the peer list instead of re-iterating it once per permission, inserting each peer into the whitelists it is allowed in. No behavioural change, this just avoids the redundant iterations.
lcruz99
force-pushed
the
refactor_peer_permissions
branch
from
7da5a59 to
134f9a6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build the per-permission peer whitelists in a single pass over the peer list instead of re-iterating it once per permission, inserting each peer into the whitelists it is allowed in.
No behavioural change, this just avoids the redundant iterations.
☑️ Definition of Done checklist