Harden hosted MCP runner web-auth flows#74
Merged
sdb001 merged 1 commit intoJul 3, 2026
Merged
Conversation
Collaborator
|
Local review on this PR: the focused checks pass and I did not find a direct blocker in the agent-cli changes. Checks run:
I would hold merge until Nunchi-trade/web-auth#67 narrows the INTERNAL_MCP_EXPERIMENT_TOKEN auth scope. This runner flow depends on the web-auth trusted context boundary, and #67 currently accepts that internal token through shared user-scoped auth middleware. |
sdb001
approved these changes
Jul 3, 2026
sdb001
left a comment
Collaborator
There was a problem hiding this comment.
Rechecked after the web-auth auth-scope fix in Nunchi-trade/web-auth#67. I’m comfortable approving this runner PR now.
The focused checks had already passed locally:
- python3 -m py_compile cli/mcp_server.py cli/commands/hedge.py scripts/entrypoint.py scripts/mcp_workload_experiment.py
- .venv312-review/bin/python -m pytest tests/test_mcp_gateway_context.py tests/test_entrypoint.py = 29 passed
Merge order note: this should still land after the fixed web-auth#67 layer, since it depends on that trusted context boundary.
Co-authored-by: Cursor <cursoragent@cursor.com>
2f63db6 to
72c004d
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
python3 -m pytest tests/test_mcp_gateway_context.py tests/test_entrypoint.pypython3 -m py_compile cli/mcp_server.py cli/commands/hedge.py scripts/entrypoint.py scripts/mcp_workload_experiment.pyMade with Cursor