Skip to content

[18.0][OU-FIX] l10n_it: remove xmlid for taxes as they would be partially duplicated with possible critics errors during migration#5719

Open
sergiocorato wants to merge 1 commit into
OCA:18.0from
efatto:18.0-fix-l10n_it-xml-duplication
Open

[18.0][OU-FIX] l10n_it: remove xmlid for taxes as they would be partially duplicated with possible critics errors during migration#5719
sergiocorato wants to merge 1 commit into
OCA:18.0from
efatto:18.0-fix-l10n_it-xml-duplication

Conversation

@sergiocorato

@sergiocorato sergiocorato commented Jun 15, 2026

Copy link
Copy Markdown

During migration from 17.0 of l10n_it the records with option auto_sequence="1" re-create theirs xmlids and sometimes they conflict with the existing records.

This PR remove completely them, to let Odoo re-create them safely.

This PR is for Italian module, maybe it could be a need of other localization modules too.

@OCA-git-bot OCA-git-bot added mod:openupgrade_scripts Module openupgrade_scripts series:18.0 labels Jun 15, 2026
@sergiocorato sergiocorato force-pushed the 18.0-fix-l10n_it-xml-duplication branch from 39bd316 to 9fc50bf Compare June 15, 2026 09:22
@sergiocorato sergiocorato force-pushed the 18.0-fix-l10n_it-xml-duplication branch from 9fc50bf to 788e412 Compare June 15, 2026 09:23
@sergiocorato sergiocorato marked this pull request as ready for review June 15, 2026 09:23
@sergiocorato sergiocorato changed the title [18.0][OU-FIX] l10n_it: remove xmlid for taxes as they would be partially duplicated with possible critic errors during migration [18.0][OU-FIX] l10n_it: remove xmlid for taxes as they would be partially duplicated with possible critics errors during migration Jun 15, 2026

@hbrunn hbrunn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

won't you delete manual customizations this way?

@sergiocorato

Copy link
Copy Markdown
Author

won't you delete manual customizations this way?

These reports are recreated from templates, so these manual customizations will be lost anyway.

These reports are only visible in EE but I don't use it so I don't know how they work, but how do you do customizations? They're only reports for what I can see.

@hbrunn

hbrunn commented Jun 16, 2026

Copy link
Copy Markdown
Member

yes right, people will have to live with that.

it's still weird to me that delete_records_safely_by_xml_id does not do the job here, did you investigate this? Note in any case that delete_childs does not do what you think it does: https://github.com/OCA/openupgradelib/blob/master/openupgradelib/openupgrade.py#L3638-L3642, is this possibly the problem? In my opinion, this is simply fixable by replacing "ir.ui.view" with record._name

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mod:openupgrade_scripts Module openupgrade_scripts series:18.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants