[18.0] [MIG] ai_tool

[etobella]

Migration to 18.0

No major changes.

[etobella]

@LixFerox, we are making some changes on the automation, so I would prefer to do the migration myself (actually, I have a branch)

You can review this one, so we can proceed fast and give a solution for automation too

[angelmoya]

Tested, LGTM!

[pedrobaeza]

This module name may be confusing with the repository ai-tools. I know it's not easy to put names, but I would bet this will be a frequent confusion topic.

[etobella]

Yes, certainly, however, the name of the module came before the repository idea 😉

Anyway, let's rename it to make it easier. Maybe:

• ai_oca_base (I think this fits better)
• ai_tool_base

WDYT?

[pedrobaeza]

And why not simply ai_oca? The base word for me has always been redundant.

[angelmoya]

I don't think ai_oca is the right choice here. It is way too generic for a module name.

We should maintain the reference to "tools" because this module is not the base for AI logic itself; its specific purpose is to provide the foundational support for the creation of tools for other AI modules. Calling it just ai_oca doesn't describe what it actually does.

[acysos]

I think that is better ai_tools_base. We make similar IA modules, will merge with this project, and we also call ai_tools.

Greetings

[oliverg09]

I think 'base_ai_tools' is a better alternative to 'ai_tools_base', since it follows a naming convention that's more in line with the organization's standards. It keeps the name generic and avoids potential confusion.

[etobella]

base_ai_tools is not following the repo name structure, I would prefer ai_tools_specs or ai_base_tools or ai_tools_base

[yoadria]

I think 'ai_base_tools' is better too

[oliverg09]

I think all the ideas you've proposed are excellent. What do you think about adding the suffix mcp, for example, ai_oca_tools_mcp? Ultimately, the tools that are developed will be geared towards that approach.

What do you think?

[etobella]

No, tools are not for that. I think I was not clear enough on the roadmap, but I added the change right now.

Tools are used by MCP and AI Native, For this reason it cannot include the "MCP" word.

[angelmoya]

Regarding the potential confusion with a hypothetical ai-tools repository: I believe we shouldn't let a naming debate block this contribution.

If we eventually create an ai-tools repository, we can simply name this module ai_tool (underscore) or treat it as the base package without the 'base' prefix, which is redundant. A cleaner name like ai_tool allows for natural extensions later (ai_tool_sale, ai_tool_purchase, etc.).

Whether the repo uses a hyphen and the module an underscore is standard practice in Odoo. Can we move forward with the current name or a close variation to unblock the merge?

[etobella]

From my side, the name is ok. We can keep it this way.

[pedrobaeza]

I won't block.

[lorenzomorandini]

Did not find any errors while testing it on my own instance.

[pedrobaeza]

/ocabot migration ai_tool
/ocabot merge nobump

[OCA-git-bot]

What a great day to merge this nice PR. Let's do it!
Prepared branch 18.0-ocabot-merge-pr-69-by-pedrobaeza-bump-nobump, awaiting test results.

[OCA-git-bot]

There's no issue in this repo with the title 'Migration to version 18.0' and the milestone 18.0, so not possible to add the comment.

[OCA-git-bot]

Congratulations, your PR was merged at 9bed43d. Thanks a lot for contributing to OCA. ❤️

[lorenzomorandini]

@LixFerox, we are making some changes on the automation, so I would prefer to do the migration myself (actually, I have a branch)

You can review this one, so we can proceed fast and give a solution for automation too

Hi, is the automation PR ready or still working on it?

[etobella]

I will make the PR between today and monday, do not worry 😉