Skip to content

[16.0][FIX] payroll_contract_advantages: enforce unique advantage template per contract#213

Open
CristianoMafraJunior wants to merge 1 commit into
OCA:16.0from
CristianoMafraJunior:16.0-sql_contraints
Open

[16.0][FIX] payroll_contract_advantages: enforce unique advantage template per contract#213
CristianoMafraJunior wants to merge 1 commit into
OCA:16.0from
CristianoMafraJunior:16.0-sql_contraints

Conversation

@CristianoMafraJunior

@CristianoMafraJunior CristianoMafraJunior commented Sep 21, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Problem

The model hr.contract.advantage allowed duplicate records with the same contract_id and advantage_template_id

cc @kaynnan @marcelsavegnago @WesleyOliveira98

@OCA-git-bot

OCA-git-bot commented Sep 21, 2025

Copy link
Copy Markdown
Contributor

Hi @nimarosa,
some modules you are maintaining are being modified, check this out!

kaynnan
kaynnan approved these changes Sep 26, 2025
View reviewed changes

@kaynnan kaynnan left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot

OCA-git-bot commented Sep 26, 2025

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@kaynnan

kaynnan commented Sep 28, 2025

Copy link
Copy Markdown

ping @OCA/payroll-maintainers

@marcelsavegnago

marcelsavegnago commented Oct 3, 2025

Copy link
Copy Markdown
Member

ping @OCA/payroll-maintainers

@CristianoMafraJunior

CristianoMafraJunior commented Nov 3, 2025

Copy link
Copy Markdown
Member Author

ping @nimarosa

@CristianoMafraJunior

CristianoMafraJunior commented Jan 11, 2026

Copy link
Copy Markdown
Member Author

ping @OCA/payroll-maintainers

@CristianoMafraJunior

CristianoMafraJunior commented Apr 16, 2026

Copy link
Copy Markdown
Member Author

@nimarosa review?

BhaveshHeliconia
BhaveshHeliconia approved these changes Jun 9, 2026
View reviewed changes

@BhaveshHeliconia BhaveshHeliconia left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rvalyi rvalyi rvalyi approved these changes

+4 more reviewers

@marcelsavegnago marcelsavegnago marcelsavegnago approved these changes

@kaynnan kaynnan kaynnan approved these changes

@WesleyOliveira98 WesleyOliveira98 WesleyOliveira98 approved these changes

@BhaveshHeliconia BhaveshHeliconia BhaveshHeliconia approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@CristianoMafraJunior @OCA-git-bot @kaynnan @marcelsavegnago @rvalyi @WesleyOliveira98 @BhaveshHeliconia