[19.0][MIG] payroll_account: Migration to 19.0

[CristianoMafraJunior]

Related #228

cc @tishmen @nimarosa @dreispt

[Yusuke1998]

LGTM!

[stferraro]

LGTM!

[marcelsavegnago]

LGTM

[Karla-Villegas]

Issue Report: Field Error during Salary Rule Accounting Configuration
Description:
An RPC_ERROR occurs when attempting to assign accounting accounts (Debit/Credit) to a Salary Rule. The system fails to load the account list or validate the input because it references a deprecated field in Odoo 19.

Steps to Reproduce:

Navigate to Payroll > Configuration > Salary Rules.

Open a Salary Rule (e.g., Basic Salary).

Go to the Accounting (Contabilidad) tab.

Try to select or type an account in the Debit Account (Cuenta deudora) or Credit Account (Cuenta acreedora) fields.

Observed Behavior:
The system throws a ValueError: Invalid field account.account.deprecated in condition ('deprecated', '=', False). This prevents any accounting mapping for payroll.

`Error de servidor de Odoo

RPC_ERROR
Odoo Server Error

Occured on oca-payroll-19-0-pr260-0621f423ffa2.runboat.odoo-community.org on model account.account on 2026-05-14 18:23:02 GMT

Traceback (most recent call last):
File "/opt/odoo/odoo/orm/domains.py", line 914, in __get_field
field = model._fields[field_name]
KeyError: 'deprecated'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
File "/opt/odoo/odoo/http.py", line 2302, in _serve_db
return service_model.retrying(serve_func, env=self.env)
File "/opt/odoo/odoo/service/model.py", line 188, in retrying
result = func()
File "/opt/odoo/odoo/http.py", line 2357, in _serve_ir_http
response = self.dispatcher.dispatch(rule.endpoint, args)
File "/opt/odoo/odoo/http.py", line 2572, in dispatch
result = self.request.registry['ir.http']._dispatch(endpoint)
File "/opt/odoo/odoo/addons/base/models/ir_http.py", line 355, in _dispatch
result = endpoint(**request.params)
File "/opt/odoo/odoo/http.py", line 811, in route_wrapper
result = endpoint(self, *args, **params_ok)
File "/opt/odoo/addons/web/controllers/dataset.py", line 32, in call_kw
return call_kw(request.env[model], method, args, kwargs)
File "/opt/odoo/odoo/service/model.py", line 97, in call_kw
result = method(recs, *args, **kwargs)
File "/opt/odoo/addons/web/models/models.py", line 54, in web_name_search
id_name_pairs = self.name_search(name, domain, operator, limit)
File "/opt/odoo/addons/account/models/account_account.py", line 827, in name_search
return super().name_search(name, domain, operator, limit)
File "/opt/odoo/odoo/orm/models.py", line 1542, in name_search
records = self.search_fetch(domain, ['display_name'], limit=limit)
File "/opt/odoo/odoo/orm/models.py", line 1408, in search_fetch
query = self._search(domain, offset=offset, limit=limit, order=order or self._order)
File "/opt/odoo/odoo/orm/models.py", line 5364, in _search
domain = domain.optimize_full(self)
File "/opt/odoo/odoo/orm/domains.py", line 445, in optimize_full
return self._optimize(model, OptimizationLevel.FULL)
File "/opt/odoo/odoo/orm/domains.py", line 459, in _optimize
previous, domain = domain, domain._optimize_step(model, next_level)
File "/opt/odoo/odoo/orm/domains.py", line 653, in _optimize_step
children = self._flatten(child._optimize(model, level) for child in self.children)
File "/opt/odoo/odoo/orm/domains.py", line 608, in _flatten
for child in children:
File "/opt/odoo/odoo/orm/domains.py", line 653, in
children = self._flatten(child._optimize(model, level) for child in self.children)
File "/opt/odoo/odoo/orm/domains.py", line 459, in _optimize
previous, domain = domain, domain._optimize_step(model, next_level)
File "/opt/odoo/odoo/orm/domains.py", line 938, in _optimize_step
field, property_name = self.__get_field(model)
File "/opt/odoo/odoo/orm/domains.py", line 916, in __get_field
self._raise("Invalid field %s.%s", model._name, field_name)
File "/opt/odoo/odoo/orm/domains.py", line 901, in _raise
raise error(message % (*args, self.field_expr, self.operator, self.value))
ValueError: Invalid field account.account.deprecated in condition ('deprecated', '=', False)

The above server error caused the following client error:
RPC_ERROR: Odoo Server Error
RPC_ERROR
at makeErrorFromResponse (http://oca-payroll-19-0-pr260-0621f423ffa2.runboat.odoo-community.org/web/assets/cc4dd32/web.assets_web.min.js:3197:165)
at XMLHttpRequest. (http://oca-payroll-19-0-pr260-0621f423ffa2.runboat.odoo-community.org/web/assets/cc4dd32/web.assets_web.min.js:3204:13)`

[Karla-Villegas]

Hi, I've detected an RPC_ERROR that is blocking the accounting configuration of salary rules in Odoo 19. I've attached a detailed report below with the steps to reproduce it and the technical traceback. I'll be waiting for the fix to continue with the payroll testing.

[stferraro]

change deprecated = False with active = False in hr_salary_rule.py @CristianoMafraJunior