Skip to content

[19.0][FIX] fs_attachment: error on http stream#632

Open
arielbarreiros96 wants to merge 1 commit into
OCA:19.0from
arielbarreiros96:19.0-fix-fs_attachment
Open

[19.0][FIX] fs_attachment: error on http stream#632
arielbarreiros96 wants to merge 1 commit into
OCA:19.0from
arielbarreiros96:19.0-fix-fs_attachment

Conversation

@arielbarreiros96

@arielbarreiros96 arielbarreiros96 commented Jun 9, 2026

Copy link
Copy Markdown

This fix is intended to fix #631

Noticed the error when trying to load /doc endpoint

Changes are:

  • super of _to_http_stream on ir.attachment
  • small retouch on imports for preventing circular importing
  • tests

@OCA-git-bot

Copy link
Copy Markdown
Contributor

Hi @lmignon,
some modules you are maintaining are being modified, check this out!

@rrebollo rrebollo left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review. LGTM!
Would you be so kind as to review mine (#634) in return?

@arielbarreiros96 arielbarreiros96 changed the title [FIX] fs_attachment: error on http stream [19.0][FIX] fs_attachment: error on http stream Jun 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants