Skip to content

Bugfix/ux updates - #397

Merged
MigrainePanda merged 13 commits into
OSU-MC:developmentfrom
MigrainePanda:bugfix/ux-updates
May 6, 2026
Merged

Bugfix/ux updates#397
MigrainePanda merged 13 commits into
OSU-MC:developmentfrom
MigrainePanda:bugfix/ux-updates

Conversation

@MigrainePanda

@MigrainePanda MigrainePanda commented Mar 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Pull Request

Screenshots

Description

Fixes some different issues that came up while manually testing:

  • Fixes underline to indicate current tab did not show on Gradebook
  • Adds empty settings page to prevent error on navigate
  • Removes duplicate login page at /src/login.jsx
  • Removes TODO comment to setup CORS in apiUtils.js
  • Fixes bug that expires all sessions for userId instead of most recent
  • Fixes leftover TODO comment to fix api when test is passing
  • Fixes leftover TODO test for question not in course
  • Fixes leftover TODO show unpublished lectures for instructor view from gradebook
  • Fixes leftover TODO show only published lectures for student view from gradebook
  • Adds '(required)' to course creation entry boxes for submission clarity
  • Changes default section number to 1 when creating new section (instead of 0)
  • Fixes case where current tab underline didn't show after clicking 'View' from course home page
  • Adds back button when viewing question as student
  • Fixes tab navigation as student

Fixes #363
Fixes #359
Fixes #358
Fixes #349
Fixes #348

Additional Information

Checklist:

Before you submit your Pull Request, please make sure you have completed the following tasks:

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.
  • I have tagged my PR with the appropriate label(s).

@MigrainePanda
Fix Tabs underline to work when endpoints have similar paths
2f1ce95 
ex. this always underlined Lectures because it used arr.find([_, path] => path.includes())
["Lectures", `sections/${sectionId}`],
["Gradebook", `sections/${sectionId}/grades`],
@MigrainePanda
Add empty settings page to fix navigation fail
ff34212
@MigrainePanda
Remove duplicate Login page
9dc8aeb
@MigrainePanda
Remove TODO setup CORS as it is not needed in this file
eb1e446
@MigrainePanda MigrainePanda self-assigned this Mar 9, 2026
@MigrainePanda MigrainePanda added the bug Something isn't working label Mar 9, 2026
@MigrainePanda
MigrainePanda requested a review from a team as a code owner March 9, 2026 13:39
@MigrainePanda MigrainePanda added the development Updates and modifications to development/deployment tools label Mar 9, 2026
@MigrainePanda
Fix bug that expires all sessions for userId instead of most recent
743dc7a 
Fixes OSU-MC#363: Leftover TODO: Expire the most recent user session
@MigrainePanda
MigrainePanda requested a review from a team as a code owner April 6, 2026 19:08
@MigrainePanda
Fix Leftover TODO: "fix api" in test "should create a valid course re…
6ead510 
…cord with a published course"

Fixes OSU-MC#359
@MigrainePanda
Fix Leftover TODO: Correct the test "should resopond with 404 for get…
ac4c368 
…ting a question that does not exist in this course"

Fixes OSU-MC#358
@MigrainePanda
Fix Leftover TODO: show published/unpublished lectures
2013ffd 
Leftover TODO: make it so that studet [sic] sees only the published lectures: Grades component
Fixes OSU-MC#349

Leftover TODO: make it so that instruct [sic] sees all lecures regardless of published or not: Grades component
Fixes OSU-MC#348
@MigrainePanda MigrainePanda moved this from Backlog to Review in classroom-polling Apr 25, 2026
@LaserBread

LaserBread commented May 6, 2026

Copy link
Copy Markdown
Contributor

It looks good

@LaserBread
LaserBread enabled auto-merge May 6, 2026 00:59
@LaserBread
LaserBread disabled auto-merge May 6, 2026 00:59
@LaserBread LaserBread moved this from Review to Done in classroom-polling May 6, 2026
@LaserBread LaserBread moved this from Done to Review in classroom-polling May 6, 2026
LaserBread
LaserBread approved these changes May 6, 2026
View reviewed changes

@LaserBread LaserBread left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything was tested and runs fine

@github-project-automation github-project-automation Bot moved this from Review to In Progress in classroom-polling May 6, 2026
@MigrainePanda
MigrainePanda added this pull request to the merge queue May 6, 2026
Merged via the queue into OSU-MC:development with commit ecdae85 May 6, 2026
8 checks passed
@MigrainePanda
MigrainePanda deleted the bugfix/ux-updates branch May 6, 2026 05:16
@github-project-automation github-project-automation Bot moved this from In Progress to Done in classroom-polling May 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment