Fix apply process not resolving parameters from an enclosing user-d… - #532
Merged
Conversation
…efined process (e.g. parameterized offset/threshold math) inside its callback. Open-EO/openeo-geopyspark-driver#1739
EmileSonneveld
commented
Sep 7, 2026
soxofaan
reviewed
Sep 7, 2026
soxofaan
left a comment
soxofaan
left a comment
Member
There was a problem hiding this comment.
Overall I'm not completely sure this should be "fixed" by just substituting parameters in openeo-python-driver.
What is also missing is falling back on the default value of a parameter
Member
Author
|
@soxofaan Default parameters seem to be already filled in when returning |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…efined process (e.g. parameterized offset/threshold math) inside its callback. Open-EO/openeo-geopyspark-driver#1739
Written with copilot. Needs review