upstream-sync: sync Prebid.js 10.16.0 → 10.17.0 - #66
Merged
Conversation
![null[bot]](https://github.githubassets.com/images/gravatars/gravatar-user-420.png){kind=avatar}
… (#14018) * fix: Update ConnectID Adapter to respect storage type configuration. * refactor: Improve ConnectID storage type handling with constants and documentation.
* Fix Vidazoo utils screen resolution detection * remove duplication --------- Co-authored-by: Demetrio Girardi <dgirardi@prebid.org>
* Permutive modules: centralize gvl id * Set gvlid to null in permutiveIdentityManagerIdSystem * Set gvlid to null in permutiveRtdProvider.json * Set gvlid to null for Permutive components * Fix JSON formatting by adding missing newline * Fix missing newline in permutiveIdentityManagerIdSystem.json Add missing newline at the end of the JSON file. * Update permutiveRtdProvider.json
* feat: add url cleaning functionality Add configurable URL cleaning options to strip query parameters and fragments before sending URLs to Neuwo API: - stripAllQueryParams: removes all query parameters - stripQueryParamsForDomains: removes all params for specific domains/subdomains - stripQueryParams: removes specific named parameters - stripFragments: removes URL hash fragments * test: add tests for url cleaning functionality Add test cases for cleanUrl function covering: - Query parameter stripping (all, domain-specific, selective) - Fragment stripping and combinations - Edge cases (malformed URLs, encoding, delimiters) - Domain/subdomain matching logic - Option priority and fallthrough behavior - Integration tests with getBidRequestData * docs: update documentation for url cleaning Update module documentation to include: - URL cleaning configuration options and examples - Parameter table with stripAllQueryParams, stripQueryParamsForDomains, stripQueryParams, stripFragments - `npm ci` as dependencies installation command - Linting section with eslint command - Adjust commands examples - Update test commands to use test-only and test-only-nobuild - Update example page to include URL cleaning functionality - Unified commands between the example file and the module readme - Improve input structure on the example page - Enable saving input values on the example page to facilitate manual testing - Update contact information * Neuwo RTD Module feat: add API response caching - Added `enableCache` parameter (default: `true`) to cache API responses and avoid redundant requests during the page session - Implemented `clearCache()` function for testing purposes - Updated *modules/neuwoRtdProvider.js* to store responses in `globalCachedResponse` and reuse them when caching is enabled - Added cache control UI to *integrationExamples/gpt/neuwoRtdProvider_example.html* with checkbox and state persistence - Updated *modules/neuwoRtdProvider.md* documentation with caching configuration details - Added test coverage in *test/spec/modules/neuwoRtdProvider_spec.js* for both enabled and disabled cache scenarios --------- Co-authored-by: grzgm <125459798+grzgm@users.noreply.github.com>
Bumps [min-document](https://github.com/Raynos/min-document) from 2.19.0 to 2.19.2. - [Commits](Raynos/min-document@v2.19.0...v2.19.2) --- updated-dependencies: - dependency-name: min-document dependency-version: 2.19.2 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Demetrio Girardi <dgirardi@prebid.org>
Bumps [tar-fs](https://github.com/mafintosh/tar-fs) from 3.0.9 to 3.1.1. - [Commits](mafintosh/tar-fs@v3.0.9...v3.1.1) --- updated-dependencies: - dependency-name: tar-fs dependency-version: 3.1.1 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Patrick McCann <patmmccann@gmail.com>
Bumps and [js-yaml](https://github.com/nodeca/js-yaml). These dependencies needed to be updated together. Updates `js-yaml` from 3.14.1 to 3.14.2 - [Changelog](https://github.com/nodeca/js-yaml/blob/master/CHANGELOG.md) - [Commits](nodeca/js-yaml@3.14.1...3.14.2) Updates `js-yaml` from 4.1.0 to 4.1.1 - [Changelog](https://github.com/nodeca/js-yaml/blob/master/CHANGELOG.md) - [Commits](nodeca/js-yaml@3.14.1...3.14.2) --- updated-dependencies: - dependency-name: js-yaml dependency-version: 3.14.2 dependency-type: indirect - dependency-name: js-yaml dependency-version: 4.1.1 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
# Conflicts: # integrationExamples/gpt/neuwoRtdProvider_example.html
* Page view ID. * Page view ID. * Removed console.log. * Removed unused import. * Improved example. * Fixed some tests.
Contributor
|
Resolved conflict for
|
* CI: increase karma browserNoActivityTimeout * try decreasing * increase test timeout * Fix fintezaAnalytics tests * Increase number of test chunks * Fix number of chunks * Extract save-wdir action * use matrix * simplify * fix chunk def * fix concurrency key * fix test cmd * Output concurrency * Fix concurrency key again * only save coverage if it exists * adjust max-parallel * collect coverage results * temp disable e2e * rename serialize to browserstack * Use wdir to get access to local action * fix github_output-s * set up node, fix coverage cache keys * temporarily enable coverage on nofeatures * skip browserstack step when not using browserstack * key prefix * debug output * debug * remove some debug output * script syntax * matrix output * adjust matrix output * fixes * use artifacts directly * cleanup outputs * use artifacts instead of cache * consolidate * specify path * debug * build when there is no build * include hidden files * overwrite artifacts * try save/load * adjust load * try skipping untar * more debug * Remove debug output * cleanup dependencies * Adjust timeouts * adjust overall timeout * adjust timeouts again * fix finteza tests * adjust timeouts * use build name from env * Clear browserstack sessions * Always clean up sessions * sessions cannot be terminated via api * adjust capture timeout * skip build when there is no build cmd * increase retries * adjust timeouts * add chunk no in build name * Fix coveralls * isolate browserstack tests * Revert "isolate browserstack tests" This reverts commit 2ebfa9d2b4dc4b4baf71e448149e6321ff218da6.
Contributor
|
Resolved conflict for Turned out less risky than it first looked. Our fork already had the "target" reusable-workflow chunked-test architecture (
Note: the new composite actions use |
* try safari testing * try macos-latest * adjust save/load * adjust again * why * adjust -C * try safarinative * use SafariNative * separate build from run-tests * browser tests * add safari * refactor * use setup step * add firefoxHeadless * add edge * try force-local * temporarily remove build logic testing * --force-local only on win * add npm install to build * run npm install on windows * use script to generate id * use --force-local on save as well * setup edge * remove run npm install option * enable debug logging * try edge headless * define EdgeHeadless * try chromium edge * remove edge launcher * disable debug logging * add build logic test step * set shell bash * move id generation to actions/save * browser_testing.json * fix coverage * add browerstack * fix bstack secrets * remove unnecessary checkout * Clean up unused input * try clearing localStorage
Contributor
|
Resolved conflict for Only conflict was in |
Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 5 to 6. - [Release notes](https://github.com/actions/download-artifact/releases) - [Commits](actions/download-artifact@v5...v6) --- updated-dependencies: - dependency-name: actions/download-artifact dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Patrick McCann <patmmccann@gmail.com>
getPageViewIdForBidder (added by cherry-picked #14051) assumed pbjsInstance.pageViewIdPerBidder was already a Map, initialized only as a side effect of src/prebid.ts loading. Isolated test bundles (and CI's per-chunk isolated webpack builds) that don't happen to also load prebid.ts crash with 'Cannot read properties of undefined (reading has)'.
The test raced two real setTimeouts (0ms clear vs 5ms fire) with no guaranteed ordering, causing an intermittent failure on Safari in CI (clearTimeout losing the race under load). Switched to sinon fake timers so the clear is synchronous and deterministic before any simulated time advances.
Matches upstream's behavior at 10.17.0, which runs coveralls unconditionally. Our fork had added 'if: false #REMOVE ONCE REPO IS PUBLIC' as a private-repo placeholder; removing it now per dev decision.
Coverage Report for CI Build 30486198997Warning Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes. Coverage increased (+0.002%) to 91.477%Details
Uncovered Changes
Coverage Regressions89 previously-covered lines in 7 files lost coverage.
Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prebid.js Sync:
10.16.0→10.17.0This PR was auto-generated by the Sync with Upstream Prebid.js workflow.
Prebid 10.17.0 Release Page
✅ Applied Commits
⏭️ Skipped Commits
These commits were intentionally skipped because they made changes to files matching
BidAdapter:❌ Conflicting Commits (require manual resolution)