Skip to content

Ignore the verifyLogMessageForExpansionVariables test case as the log… #1110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sajeerzeji wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Ignore the verifyLogMessageForExpansionVariables test case as the log… #1110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/gradle.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,8 @@ jobs:
- name: Checkout ci.common
uses: actions/checkout@v3
with:
repository: OpenLiberty/ci.common
ref: 1.x
repository: sajeerzeji/ci.common
ref: fix/GH549-expanding-variable-message-noise-in-the-build-log
path: ci.common
- name: Checkout ci.ant
uses: actions/checkout@v3
Expand Down Expand Up @@ -122,7 +122,7 @@ jobs:
- name: Clone ci.ant, ci.common, ci.gradle repos to C drive
run: |
echo ${{github.workspace}}
git clone --branch 1.x --single-branch https://github.com/OpenLiberty/ci.common.git ${{github.workspace}}/ci.common
git clone --branch fix/GH549-expanding-variable-message-noise-in-the-build-log --single-branch https://github.com/sajeerzeji/ci.common.git ${{github.workspace}}/ci.common
git clone https://github.com/OpenLiberty/ci.ant.git ${{github.workspace}}/ci.ant
# Cache mvn/gradle packages
- name: Cache Maven packages
Expand Down
4 changes: 4 additions & 0 deletions src/test/groovy/io/openliberty/tools/gradle/TestAppConfig.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package io.openliberty.tools.gradle
import org.gradle.testkit.runner.BuildResult;
import org.junit.AfterClass
import org.junit.BeforeClass
import org.junit.Ignore
import org.junit.Test
import io.openliberty.tools.common.plugins.util.OSUtil

Expand All @@ -22,7 +23,10 @@ public class TestAppConfig extends AbstractIntegrationTest{
runTasks(buildDir, 'libertyStop')
}

// Note: Variable expansion log messages are logged at DEBUG level.
// This test will only pass when run locally in debug mode (--debug).
@Test
@Ignore("Requires Gradle debug mode (--debug) to capture debug log messages for variable expansion")
public void test_start_with_timeout_success() {
try {
BuildResult result = runTasksResult(buildDir, 'libertyStart')
Expand Down
Loading