Skip to content

fix(maven coords): Added in logic to pull Maven coordinates from .fea… - #35694

Closed
FezzyBug wants to merge 1 commit into
OpenLiberty:integrationfrom
FezzyBug:maven_coords_gen_doc_patch
Closed

FezzyBug wants to merge 1 commit into
OpenLiberty:integrationfrom
FezzyBug:maven_coords_gen_doc_patch

Conversation

@FezzyBug

@FezzyBug FezzyBug commented Sep 3, 2026

Copy link
Copy Markdown

Resolves #14633

The mavenCoordinates attribute has been present on .feature file constituents for some time but was never read or rendered in the generated ESA description HTML.

This change adds a Maven Coordinates section to EsaDescriptionHtmlGenerator:

  • Added getMavenCoordinates() — reads mavenCoordinates from each Subsystem-Content constituent, validates the groupId:artifactId:version format, and deduplicates (e.g. grpc-1.0 declares the same coordinate on two jar constituents — these collapse to one rendered block).
  • Updated generateDescriptionHtml() — appends a Maven Coordinates section with a <dependency> snippet per unique coordinate, scoped as provided. Section is omitted entirely when no coordinates are declared.

48 public features will now display Maven dependency snippets. Features without mavenCoordinates attributes are unaffected. No runtime behaviour is changed.


  • I have considered the risk of behavior change or other zero migration impact — additive, documentation-only change to generated HTML. No runtime code, APIs, SPIs, or feature resolution logic are modified.
  • This PR resolves Issue Add Maven coordinates to generated feature docs #14633. Not a release bug fix (new enhancement).

…ture - omits duplicates and renders bundles as defined.
@FezzyBug FezzyBug self-assigned this Sep 3, 2026
@FezzyBug

FezzyBug commented Sep 3, 2026 •

Copy link
Copy Markdown
Author

!build (view Open Liberty Personal Build - ❌ completed with errors/failures.)

Note: Target locations of links might be accessible only to IBM employees.

@LibbyBot

LibbyBot commented Sep 3, 2026

Copy link
Copy Markdown
Member

Code analysis and actions

DO NOT DELETE THIS COMMENT.
  • 1 product code files were changed.
  • Please describe in a separate comment how you tested your changes.

@FezzyBug

FezzyBug commented Sep 5, 2026

Copy link
Copy Markdown
Author

Code analysis and actions

DO NOT DELETE THIS COMMENT.

* 1 product code files were changed.

* **Please describe in a separate comment how you tested your changes.**

Testing was performed locally against the built wlp-generateRepositoryContent.jar.

Unit tests -> EsaDescriptionHtmlGeneratorTest (kept local and not pushed):

  • getMavenCoordinates returns the correct deduplicated coordinate list for a feature
    with multiple distinct coordinates
  • getMavenCoordinates returns an empty list when no mavenCoordinates attributes
    are declared on any constituent
  • getMavenCoordinates deduplicates when two constituents share the same coordinate
    (covers the real grpc-1.0 / grpcClient-1.0 case)
  • generateDescriptionHtml emits the Maven Coordinates heading, content div, and
    correctly structured <dependency> blocks when coordinates are present
  • generateDescriptionHtml emits no Maven section when no coordinates are declared
  • generateDescriptionHtml renders a deduplicated coordinate exactly once in HTML

@FezzyBug

FezzyBug commented Sep 5, 2026 •

Copy link
Copy Markdown
Author

!build (view Open Liberty Personal Build - ⚠️ completed with warnings.)

Note: Target locations of links might be accessible only to IBM employees.

@LibbyBot

LibbyBot commented Sep 5, 2026

Copy link
Copy Markdown
Member

Code analysis and actions

DO NOT DELETE THIS COMMENT.
  • 1 product code files were changed.
  • Please describe in a separate comment how you tested your changes.

1 similar comment
@LibbyBot

LibbyBot commented Sep 5, 2026

Copy link
Copy Markdown
Member

Code analysis and actions

DO NOT DELETE THIS COMMENT.
  • 1 product code files were changed.
  • Please describe in a separate comment how you tested your changes.

@LibbyBot

LibbyBot commented Sep 5, 2026

Copy link
Copy Markdown
Member

https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?pipelineId=552ea2cb-8992-4c98-8670-8a6b6aef3f6f - Open Liberty Personal Build completed with errors/failures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

Add Maven coordinates to generated feature docs

2 participants