Netty autoread http layered full by mrsaldana · Pull Request #35754 · OpenLiberty/open-liberty

mrsaldana · 2026-09-10T18:42:56Z

I have considered the risk of behavior change or other zero migration impact (https://github.com/OpenLiberty/open-liberty/wiki/Behavior-Changes).
If this PR fixes an Issue, the description includes "Fixes #FILLMEIN" or "Resolves #FILLMEIN" (verify release bug label if applicable: https://github.com/OpenLiberty/open-liberty/wiki/Open-Liberty-Conventions).
If this PR resolves an external Known Issue (including APARS), the description includes "Fixes #FILLMEIN" or "Resolves #FILLMEIN".

… and partial fixes

LibbyBot · 2026-09-10T21:05:26Z

Code analysis and actions

DO NOT DELETE THIS COMMENT.

49 product code files were changed.
Please describe in a separate comment how you tested your changes.

mrsaldana · 2026-09-10T21:52:23Z

Commit 94ca838

Fix premature request closure when endpoint pause occurs before Netty's quiesce callback. Retain accepted connection groups and their dedicated accept executors so active requests can finish through the existing graceful shutdown handling.

Specifically seen in

com.ibm.ws.zos.connect.service.client.rest_fat -> ZosConnectServiceRestClientBasicAsyncFATTest

mrsaldana · 2026-09-10T21:52:38Z

!fullpb
(view Open Liberty Personal Build - ❌ completed with errors/failures.)
extra.fat.ant.options=-Dglobal.jvm.args="-Dcom.ibm.ws.beta.edition=true"
global.trace.spec==info:com.ibm.ws.http=all

Note: Target locations of links might be accessible only to IBM employees.

LibbyBot · 2026-09-10T22:00:42Z

Code analysis and actions

DO NOT DELETE THIS COMMENT.

49 product code files were changed.
Please describe in a separate comment how you tested your changes.

mrsaldana · 2026-09-10T22:48:14Z

!fullpb
(view Open Liberty Personal Build - ❌ completed with errors/failures.)
extra.fat.ant.options=-Dglobal.jvm.args="-Dcom.ibm.ws.beta.edition=true"

Note: Target locations of links might be accessible only to IBM employees.

LibbyBot · 2026-09-10T22:57:09Z

Code analysis and actions

DO NOT DELETE THIS COMMENT.

49 product code files were changed.
Please describe in a separate comment how you tested your changes.

mrsaldana · 2026-09-11T14:02:03Z

!fullpb
(view Open Liberty Personal Build - ❌ completed with errors/failures.)
extra.fat.ant.options=-Dglobal.jvm.args="-Dcom.ibm.ws.beta.edition=true"

Note: Target locations of links might be accessible only to IBM employees.

LibbyBot · 2026-09-11T14:13:32Z

Code analysis and actions

DO NOT DELETE THIS COMMENT.

49 product code files were changed.
Please describe in a separate comment how you tested your changes.

mrsaldana · 2026-09-11T16:47:46Z

!fullpb
(view Open Liberty Personal Build - ❌ completed with errors/failures.)
extra.fat.ant.options=-Dglobal.jvm.args="-Dcom.ibm.ws.beta.edition=true"
global.trace.spec==info:com.ibm.ws.http=all

Note: Target locations of links might be accessible only to IBM employees.

LibbyBot · 2026-09-11T17:32:33Z

Code analysis and actions

DO NOT DELETE THIS COMMENT.

49 product code files were changed.
Please describe in a separate comment how you tested your changes.

mrsaldana · 2026-09-11T18:06:07Z

Commit 74b14a9

Applies the existing finish enforcement for incomplete request body before the finish path queues final headers. This is to target empty HTTP/1 response not showing Connection: Close when the request requires closing the connection, letting the client know not to reuse the connection.

Related to test failure:

com.ibm.ws.jaxrs.2.0_fat -> MediaTypeTestServlet.testClientSendsAcceptMatchingMethodProducesAnnotation_EE11_FEATURES

This is an intermittent NoHttpresponseException

mrsaldana · 2026-09-13T01:37:28Z

!fullpb
(view Open Liberty Personal Build - ❌ completed with errors/failures.)
extra.fat.ant.options=-Dglobal.jvm.args="-Dcom.ibm.ws.beta.edition=true"
global.trace.spec==info:com.ibm.ws.http=all

Note: Target locations of links might be accessible only to IBM employees.

LibbyBot · 2026-09-13T01:44:47Z

Code analysis and actions

DO NOT DELETE THIS COMMENT.

49 product code files were changed.
Please describe in a separate comment how you tested your changes.

mrsaldana · 2026-09-13T17:18:46Z

!fullpb
(view Open Liberty Personal Build - ❌ completed with errors/failures.)
extra.fat.ant.options=-Dglobal.jvm.args="-Dcom.ibm.ws.beta.edition=true"
global.trace.spec==info:com.ibm.ws.http=all

Note: Target locations of links might be accessible only to IBM employees.

LibbyBot · 2026-09-13T17:26:07Z

Code analysis and actions

DO NOT DELETE THIS COMMENT.

49 product code files were changed.
Please describe in a separate comment how you tested your changes.

mrsaldana · 2026-09-17T02:09:48Z

!fullpb
(view Open Liberty Personal Build - ❌ completed with errors/failures.)
extra.fat.ant.options=-Dglobal.jvm.args="-Dcom.ibm.ws.beta.edition=true"
global.trace.spec==info:com.ibm.ws.http=all

Note: Target locations of links might be accessible only to IBM employees.

mrsaldana · 2026-09-17T02:10:00Z

!fullpb
(view Open Liberty Personal Build - ❌ completed with errors/failures.)
extra.fat.ant.options=-Dglobal.jvm.args="-Dcom.ibm.ws.beta.edition=true"
global.trace.spec==info:com.ibm.ws.http=all

Note: Target locations of links might be accessible only to IBM employees.

LibbyBot · 2026-09-17T02:17:55Z

Code analysis and actions

DO NOT DELETE THIS COMMENT.

49 product code files were changed.
Please describe in a separate comment how you tested your changes.

LibbyBot · 2026-09-17T02:18:03Z

Code analysis and actions

DO NOT DELETE THIS COMMENT.

49 product code files were changed.
Please describe in a separate comment how you tested your changes.

mrsaldana · 2026-09-17T13:54:48Z

!fullpb
(view Open Liberty Personal Build - ⏳InProgress)
extra.fat.ant.options=-Dglobal.jvm.args="-Dcom.ibm.ws.beta.edition=true"

Note: Target locations of links might be accessible only to IBM employees.

LibbyBot · 2026-09-17T14:03:27Z

Code analysis and actions

DO NOT DELETE THIS COMMENT.

49 product code files were changed.
Please describe in a separate comment how you tested your changes.

mrsaldana · 2026-09-17T14:13:27Z

!fullpb
(view Open Liberty Personal Build - ⏳InProgress)
extra.fat.ant.options=-Dglobal.jvm.args="-Dcom.ibm.ws.beta.edition=true"

Note: Target locations of links might be accessible only to IBM employees.

LibbyBot · 2026-09-17T14:23:15Z

Code analysis and actions

DO NOT DELETE THIS COMMENT.

49 product code files were changed.
Please describe in a separate comment how you tested your changes.

isaacrivriv

Functionally this looks good to me, thanks!

mrsaldana added 30 commits October 15, 2025 08:14

Autoread off init commit

cbf4a22

Debugging read timeout

ab38705

Additional minor additions to ensure read flow

4fc49dd

Additional debug. Adjustment to request/response init on ready

046b64d

WIP Auto read race condition investigation

e5dff23

Removing request handler

f8b29f5

Flow state debugging

24c74a5

Additional debugging changes

4bc5ae4

Considerations to isFinished streamee7

af34b82

Servlet 3.1 stable

45e9b33

Stable 3.1 (1) - Stable 4.0 (1&2), Debugging Servlet Upgrade Listener…

afd40c5

… and partial fixes

Synchronization upgrade fixes

acb32e7

Read timeout work

934b5a2

Debug cleanups

d100bed

Merge branch 'integration' into netty-transport-http-autoread

a8e083d

H2 stream maps

19f3a98

Read listener changes

8909de3

Servlet3.1.2 NPE write handler closes connection

b2d5021

Decompression and fatal flag additions

4fce8b1

clean potential ffdc npe

ecafc91

Rebase integration

c799a05

Enable auto read on upgrade, WIP

f6f74a8

Remove inputstream wait and use signalling, perf

98644d2

Merge branch 'integration' into netty-transport-http-autoread

733a413

Rebase with integration change

ad067ab

Debug cleanup

b769095

Remove additional debugging

29b0eeb

Performance contention improvements

c93017d

Read requests only from ReadFlowHandler; better upgrade signaling

25057dd

Performance review WIP

47502df

mrsaldana added 2 commits September 11, 2026 09:58

Preserve buffered upgrade read after half close on peer

a40c75d

Preserve active connections on graceful shutdown

ffbf6e3

mrsaldana force-pushed the netty-autoread-http-layered-full branch from 94ca838 to ffbf6e3 Compare September 11, 2026 14:00

Incomplete body close enforcement

74b14a9

isaacrivriv mentioned this pull request Sep 16, 2026

Autoread consolidated fixes #35794

Draft

3 tasks

Fix dispatch race seen in HTTP/2

29cf84f

isaacrivriv approved these changes Sep 17, 2026

View reviewed changes

Conversation

mrsaldana commented Sep 10, 2026

Uh oh!

LibbyBot commented Sep 10, 2026

Code analysis and actions

Uh oh!

mrsaldana commented Sep 10, 2026

Uh oh!

mrsaldana commented Sep 10, 2026 • edited by LibbyBot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

LibbyBot commented Sep 10, 2026

Code analysis and actions

Uh oh!

mrsaldana commented Sep 10, 2026 • edited by LibbyBot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

LibbyBot commented Sep 10, 2026

Code analysis and actions

Uh oh!

mrsaldana commented Sep 11, 2026 • edited by LibbyBot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

LibbyBot commented Sep 11, 2026

Code analysis and actions

Uh oh!

mrsaldana commented Sep 11, 2026 • edited by LibbyBot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

LibbyBot commented Sep 11, 2026

Code analysis and actions

Uh oh!

mrsaldana commented Sep 11, 2026

Uh oh!

mrsaldana commented Sep 13, 2026 • edited by LibbyBot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

LibbyBot commented Sep 13, 2026

Code analysis and actions

Uh oh!

mrsaldana commented Sep 13, 2026 • edited by LibbyBot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

LibbyBot commented Sep 13, 2026

Code analysis and actions

Uh oh!

mrsaldana commented Sep 17, 2026 • edited by LibbyBot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mrsaldana commented Sep 17, 2026 • edited by LibbyBot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

LibbyBot commented Sep 17, 2026

Code analysis and actions

Uh oh!

LibbyBot commented Sep 17, 2026

Code analysis and actions

Uh oh!

mrsaldana commented Sep 17, 2026 • edited by LibbyBot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

LibbyBot commented Sep 17, 2026

Code analysis and actions

Uh oh!

mrsaldana commented Sep 17, 2026 • edited by LibbyBot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

LibbyBot commented Sep 17, 2026

Code analysis and actions

Uh oh!

isaacrivriv left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

mrsaldana commented Sep 10, 2026 •

edited by LibbyBot

Loading

mrsaldana commented Sep 10, 2026 •

edited by LibbyBot

Loading

mrsaldana commented Sep 11, 2026 •

edited by LibbyBot

Loading

mrsaldana commented Sep 11, 2026 •

edited by LibbyBot

Loading

mrsaldana commented Sep 13, 2026 •

edited by LibbyBot

Loading

mrsaldana commented Sep 13, 2026 •

edited by LibbyBot

Loading

mrsaldana commented Sep 17, 2026 •

edited by LibbyBot

Loading

mrsaldana commented Sep 17, 2026 •

edited by LibbyBot

Loading

mrsaldana commented Sep 17, 2026 •

edited by LibbyBot

Loading

mrsaldana commented Sep 17, 2026 •

edited by LibbyBot

Loading