Provide a better report to help identify overrides that prevent design variables from correctly impacting the problem. - #1274
Open
Kenneth-T-Moore wants to merge 7 commits into
Conversation
…o identify problems
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is in a response to an issue where the wing aspect ratio, which is calculated in Aviary's height energy geometry from the wing area and span, was overridden with a value from the csv file. When wing area is selected as a design variable, the computed aspect ratio is no longer correct, and this impacts the drag computation.
Aviary's override system is flexible, but it allows you to create a situation like described above. To help the user understand that this might be happening, this PR adds a new section to the override report:
The report uses the OpenMDAO variable relevancy graph to detect when an override interferes with dataflow from the design variables to the constraints and objective. The 'depends on" section shows which design variables are being blocked, and the "impacts" section shows which responses this effects. The "feeds" section shows the components that are using the overriden value instead of the computed value. In this example, the wing area affects the computation of the fuselage wetted area, and this has potential impacts on the mass during flight (which is important for the final objective.)
Related Issues
Backwards incompatibilities
None
AI Usage
Disclose any AI usage in this PR, including models used and files affected.