D005 OMCSession - classes update#435
Merged
adeas31 merged 6 commits intoOpenModelica:masterfrom Apr 29, 2026
Merged
Conversation
syntron
force-pushed
the
D005-OMCSession_classes_update
branch
from
ba4e3f8 to
8361414
Compare
[(_)OMPathRunnerLocal] improve definition * fix return values * additional cleanups [__init__] define OMPathRunnerLocal for public interface [_OMPathRunnerBash] define class [__init__] define OMPathRunnerBash for public interface [OMSessionRunner] update code such that it can be used by OMPathRunnerLocal and OMPathRunner Bash
[OMCSessionPort] fix timeout handling [OMCSessionDocker*] improve data handling * move more code to OMCSessionDockerHelper * use _docker_omc_start() to differentiate classes * define cmd_prefix [OMCSessionWSL] define cmd_prefix [OMCSessionWSL] layout fix
syntron
force-pushed
the
D005-OMCSession_classes_update
branch
from
8361414 to
684d32c
Compare
adeas31
reviewed
Apr 29, 2026
Merged
…ill work for any of these classe
syntron
force-pushed
the
D005-OMCSession_classes_update
branch
from
7246c36 to
8ff6d18
Compare
* definition in OMSessionABC * move `set_timeout()` to this class * all other places use `timeout: Optional[float] = None`
syntron
force-pushed
the
D005-OMCSession_classes_update
branch
from
8ff6d18 to
39139e0
Compare
syntron
force-pushed
the
D005-OMCSession_classes_update
branch
from
0b8cf5a to
b6ec039
Compare
adeas31
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(D005) update classes in OMCSession