UndoManager: Fix removal of oldest redo steps - #2531
Open
dl3sdo wants to merge 3 commits into
Open
Conversation
Make max_undo_steps a class member and class UndoManagerTest a friend to allow testing with varying number of undo/redo steps.
The map file stores redo steps in reversed order, which are then reinserted in reversed order. When the number of loaded steps exceeded the maximum undo/redo limit, then the newest redo steps were removed instead of the oldest ones.
Add test for saving and loading a map file with undo/redo steps to verify that these steps will be executed correctly after loading. Test that limitation of undo/redo steps is done correctly if a map file is loaded that contains more steps than the maximum number of steps.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The map file stores redo steps in reversed order, which are then reinserted in reversed order. When the number of loaded steps exceeded the maximum undo/redo limit, then the newest redo steps were removed instead of the oldest ones.
Make max_undo_steps a class member and class UndoManagerTest a friend to allow testing with varying number of undo/redo steps.
Add test for saving and loading a map file with undo/redo steps to verify that these steps will be executed correctly after loading.
Test that limitation of undo/redo steps is done correctly if a map file is loaded that contains more steps than the maximum number of steps.