Repository navigation
Conversation
petrsimon
reviewed
Oct 21, 2026
petrsimon
left a comment
Contributor
There was a problem hiding this comment.
The change itself is correct and nicely scoped: exact-name list, absent stays absent, base isn't mutated, and runner-owned settings still win. Main concern is coverage: the same bug class remains for other non-secret variables the helpers read (see inline comment on the allowlist). The rest are nits.
Hyperkid123
force-pushed
the
rehor-199/opencode-operational-environment
branch
from
October 21, 2026 09:16
f92e2f2 to
1966ec5
Compare
Hyperkid123
force-pushed
the
rehor-199/opencode-operational-environment
branch
from
October 21, 2026 09:28
1966ec5 to
c3fb7f9
Compare
petrsimon
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
REHOR-199
Restore operational environment required by OpenCode Bash tools and canonical helpers. REHOR-193 transcripts showed gh calls falling back to a nonexistent Unix executor socket and claim helpers reporting missing bot email despite both settings being present in the pod.
EXECUTOR_ADDR,BOT_JIRA_EMAIL,BOT_INSTANCE_ID,BOT_MEMORY_URL,GH_USER_NAME,GL_USER_NAME,BOT_CONFIG_PATH,SLACK_NOTIFY_MODE,GH_RELEASE_UPLOAD_URL,BOT_BOARD_ID,BOT_BOARD_NAME, andSLACK_WEBHOOK_URLwhen present.SLACK_WEBHOOK_URLis an intentional configured-credential exception preserving the existing agent → helper → MCP notification contract. Missing or empty webhook retains optional no-op behavior.Blast radius
Shared OpenCode child environment used by onboarding and other native consumers. Production change is limited to 12 explicit operational names; no broad BOT_/EXECUTOR_ prefix forwarding.
Verification:
Live service connectivity and deployment remain rollout checks. Onboarding must pin the merged runner commit, rebuild an immutable image and obtain a fresh Sandbox. Existing template values need no YAML change.
Rollback plan
Revert this commit, rebuild affected runner images and restore the previous immutable image reference/pin. No database migration or API change.
Checklist
latest(image references unchanged)AI disclosure
Assisted by: OpenCode (OpenAI).